Date: Wed, 2 Dec 2015 23:36:15 +0000 (UTC) From: Navdeep Parhar <np@FreeBSD.org> To: src-committers@freebsd.org, svn-src-projects@freebsd.org Subject: svn commit: r291661 - projects/cxl_iscsi/sys/dev/cxgbe/cxgbei Message-ID: <201512022336.tB2NaF38066244@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: np Date: Wed Dec 2 23:36:14 2015 New Revision: 291661 URL: https://svnweb.freebsd.org/changeset/base/291661 Log: Remove reminders for items that have been taken care of. Modified: projects/cxl_iscsi/sys/dev/cxgbe/cxgbei/cxgbei.c projects/cxl_iscsi/sys/dev/cxgbe/cxgbei/icl_cxgbei.c Modified: projects/cxl_iscsi/sys/dev/cxgbe/cxgbei/cxgbei.c ============================================================================== --- projects/cxl_iscsi/sys/dev/cxgbe/cxgbei/cxgbei.c Wed Dec 2 23:33:33 2015 (r291660) +++ projects/cxl_iscsi/sys/dev/cxgbe/cxgbei/cxgbei.c Wed Dec 2 23:36:14 2015 (r291661) @@ -579,7 +579,7 @@ do_rx_iscsi_data(struct sge_iq *iq, cons icp->pdu_flags |= SBUF_ULP_FLAG_DATA_RCVD; icp->ip.ip_data_mbuf = m; - icp->ip.ip_data_len = m->m_pkthdr.len; /* XXXNP: round up to 4? */ + icp->ip.ip_data_len = m->m_pkthdr.len; #if 0 CTR4(KTR_CXGBE, "%s: tid %u, cpl->len dlen %u, m->m_len dlen %u", Modified: projects/cxl_iscsi/sys/dev/cxgbe/cxgbei/icl_cxgbei.c ============================================================================== --- projects/cxl_iscsi/sys/dev/cxgbe/cxgbei/icl_cxgbei.c Wed Dec 2 23:33:33 2015 (r291660) +++ projects/cxl_iscsi/sys/dev/cxgbe/cxgbei/icl_cxgbei.c Wed Dec 2 23:36:14 2015 (r291661) @@ -326,14 +326,6 @@ icl_cxgbei_conn_pdu_append_data(struct i MPASS(ic == ip->ip_conn); KASSERT(len > 0, ("%s: len is %jd", __func__, (intmax_t)len)); - /* - * XXXNP: add assertions here, after fixing the problems around - * max_data_segment_length: - * a) len should not cause the max_data_segment_length to be exceeded. - * b) all data should fit in a single jumbo16. The hardware limit just - * happens to be within jumbo16 so this is very convenient. - */ - m = ip->ip_data_mbuf; if (m == NULL) { m = m_getjcl(M_NOWAIT, MT_DATA, 0, MJUM16BYTES);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201512022336.tB2NaF38066244>