From owner-freebsd-usb@freebsd.org Sun Oct 1 18:23:16 2017 Return-Path: Delivered-To: freebsd-usb@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CF9A0E2B8B5 for ; Sun, 1 Oct 2017 18:23:16 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound1b.ore.mailhop.org (outbound1b.ore.mailhop.org [54.200.247.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id AECA76A1A4 for ; Sun, 1 Oct 2017 18:23:16 +0000 (UTC) (envelope-from ian@freebsd.org) X-MHO-User: 9a406404-a6d5-11e7-a937-4f970e858fdb X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 73.78.92.27 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [73.78.92.27]) by outbound1.ore.mailhop.org (Halon) with ESMTPSA id 9a406404-a6d5-11e7-a937-4f970e858fdb; Sun, 01 Oct 2017 18:23:20 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id v91INDtL001612; Sun, 1 Oct 2017 12:23:13 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <1506882193.22078.32.camel@freebsd.org> Subject: Re: USB/U3G: Added support for Panasonic CF-F9 GOBI 3G modem to U3G module From: Ian Lepore To: Tomasz CEDRO , Hans Petter Selasky Cc: "freebsd-usb@FreeBSD.org" Date: Sun, 01 Oct 2017 12:23:13 -0600 In-Reply-To: References: <1506465459.73082.168.camel@freebsd.org> <165556bc-c011-bebd-feee-5bbd4cb5943e@selasky.org> <1506876055.22078.24.camel@freebsd.org> <87d62aba-0b35-8b20-cf1f-9fd2de2d301a@selasky.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Oct 2017 18:23:16 -0000 On Sun, 2017-10-01 at 20:17 +0200, Tomasz CEDRO wrote: > On Sun, Oct 1, 2017 at 7:21 PM, Hans Petter Selasky > wrote: > > > > On 10/01/17 19:09, Tomasz CEDRO wrote: > > > > > > > > > On Sun, Oct 1, 2017 at 6:40 PM, Ian Lepore > > > wrote: > > > > > > > > > > > > On Sun, 2017-10-01 at 18:33 +0200, Tomasz CEDRO wrote: > > > > > > > > > > > > > > > On Wed, Sep 27, 2017 at 8:32 AM, Hans Petter Selasky > > > > asky.org > > > > > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > On 09/27/17 00:37, Ian Lepore wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Wed, 2017-09-27 at 00:30 +0200, Hans Petter Selasky > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On 09/27/17 00:11, Tomasz CEDRO wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/freebsd/freebsd/pull/115 > > > > > > > > > > > > > > > > > > :-) > > > > > > > > > > > > > > > > > The devd.conf rule should match more than just vendor > > > > > > > > and > > > > > > > > product: > > > > > > > > > > > > > > > > > > > > > > > > +# Load GOBI 2000/3000 U3G QDL modem firmware on attach > > > > > > > > / boot. > > > > > > > > +# Note: This requires additional "gobi_loader" utility > > > > > > > > to be > > > > > > > > installed, > > > > > > > > +#   as well as valid QDL driver firmware files placed > > > > > > > > in > > > > > > > > /boot/firmware/gobi. > > > > > > > > +#   If modem does not accept valid firmware try > > > > > > > > gobi_loader > > > > > > > > -2000 > > > > > > > > switch. > > > > > > > > +#   Please adjust modem VID/PID to match your device > > > > > > > > supported > > > > > > > > by > > > > > > > > u3g > > > > > > > > module. > > > > > > > > +#attach 100 { > > > > > > > > +#      match "vendor" "0x04da"; > > > > > > > > +#      match "product" "0x250e"; > > > > > > > > +#      action "/usr/local/sbin/gobi_loader /dev/cuaU0 > > > > > > > > /boot/firmware/gobi/"; > > > > > > > > +#}; > > > > > > > > > > > > > > > > Else patch looks good. > > > > > > > > > > > > > > > > --HPS > > > > > > > > > > > > > > Hard-coding /dev/cuaU0 cannot possibly be right. > > > > > > > > > > > > > > -- Ian > > > > > > > > > > > > > These three lines are missing: > > > > > > > > > > > >          match "system"          "DEVFS"; > > > > > >          match "subsystem"       "CDEV"; > > > > > >          match "type"            "CREATE"; > > > > > > > > > > > > > > > > > > --HPS > > > > > Thanks! Updated! :-) > > > > > > > > > > https://github.com/freebsd/freebsd/pull/115 > > > > > > > > > If this is to be an example, it should be correct.  Please > > > > replace the > > > > "cuaU0" with "$cdev".  (See /etc/devd/uath.conf for an > > > > example). > > > > > > > > -- Ian > > > > > > Thanks Ian! Is it okay now? I have moved this example to > > > dedicated > > > /etc/devd/u3g.conf file, and added u3g load to > > > /etc/devd/usb.conf.. if > > > syntax is okay I will verify on my laptop.. > > > > > > https://github.com/freebsd/freebsd/pull/115 > > > > > Looks good to me. Don't forget to MFC! > > > > --HPS > /etc/devd/u3g.conf: > > notify 100 { >  match "system" "USB"; >  match "subsystem" "DEVICE"; >  match "type" "ATTACH"; >  match "vendor" "0x04da"; >  match "product" "0x250e"; >  action "/usr/local/bin/gobi_loader /dev/$cdev /boot/firmware/gobi/"; > }; > > This does not work when /dev/$cdev is used.. but it works when > /dev/cuaU0 is used. Ian, could you please advise? :-) > Hmmm, then I'd have to surmise that everything in /etc/devd/uath.conf will fail the same way. I noticed earlier the events mentioned were          match "system"          "DEVFS";          match "subsystem"       "CDEV";          match "type"            "CREATE"; and I would expect $cdev to have the right value on a CDEV/CREATE event, but not necessarily on a DEVICE/ATTACH event. -- Ian