From owner-cvs-all Mon Sep 10 9:19:15 2001 Delivered-To: cvs-all@freebsd.org Received: from dragon.nuxi.com (trang.nuxi.com [66.92.13.169]) by hub.freebsd.org (Postfix) with ESMTP id C7EB437B408; Mon, 10 Sep 2001 09:18:59 -0700 (PDT) Received: (from obrien@localhost) by dragon.nuxi.com (8.11.6/8.11.1) id f8AGIoB63624; Mon, 10 Sep 2001 09:18:50 -0700 (PDT) (envelope-from obrien) Date: Mon, 10 Sep 2001 09:18:50 -0700 From: "David O'Brien" To: Peter Wemm Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern subr_prf.c src/sys/sys systm.h Message-ID: <20010910091850.A63536@dragon.nuxi.com> Reply-To: obrien@FreeBSD.org References: <20010910010642.A48947@dragon.nuxi.com> <20010910100051.6E0C238FF@overcee.netplex.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20010910100051.6E0C238FF@overcee.netplex.com.au>; from peter@wemm.org on Mon, Sep 10, 2001 at 03:00:51AM -0700 X-Operating-System: FreeBSD 5.0-CURRENT Organization: The NUXI BSD group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Mon, Sep 10, 2001 at 03:00:51AM -0700, Peter Wemm wrote: > > > This hack brought to you by some questionable ``optimizations'' in gcc-3. > > > gcc-3 takes it apon itself to convert: > > > printf("string\n") -> puts("string"); > > > and: > > > printf("a"); -> putchar('a') > > > etc. I dont know what they've been smoking over there in gcc-land, but > > > it must be pretty good stuff. > > > > > > Please folks, don't do ANY gcc3 specific commits. I am working on our > > upgrade and I need to be *totally* on top of what the compiler is doing > > to us and how it affects us. Either I deal with this, or I pass the > > torch on to others. There is plenty of work to go around in > > FreeBSD'ville that people can just use the gcc 2.95.3 for now and work on > > non-gcc3 issues. > > With this exception, the other changes I made were fixing existing problems > that gcc-2.95.3 neglected to comment on. There are still macros with > token concatenation bugs, and they are even bugs under 2.95.3. Are we not > allowed to fix those just because gcc3 highlights them? Aren't there other things you have interest to work on, than trampling on my local changes? Due to the lack of people pitching in to work on GCC for us (esp. the PITA aspects), it seems many consider working on GCC an un-fun task. (the same for the lack of anyone updating amd and dhclient and giving them attention) What I have asked for doing work that I also don't consider to be the most fun, and not at all career building[*]; is that people not tread on my work. [*] nothing I have done for FreeBSD in the past 2 years has done anything to improve my job skills. And frankly this greatly worries me in today's market. At the same time I have seen my co-workers take the opportunity to branch into new areas and make them a hot commodity in even today's job market. > And with all due respect to your testing procedures, it isn't exclusively > your job to get the kernel to work with gcc-3. Actually I thought it was -- because I cannot cut us over to a compiler that does not build a working kernel+world. So I am on top of the problems that come up with the new compiler. You are changing the way the the tree builds (adding, subtracting) options. I have some local GCC 3 changes, along with knowing about certain affects of GCC 3. You are changing the way things I know things be. I will not be chasing my tail when things change WRT gcc3 issues w/o being aware of them. (And yes, I (along with a lot of committers I know) no longer have time to read every commit message. I like many others scan the subject to see if it is something I should read.) > If you can land a valid compiler in the tree then you have succeeded. > The rest of the tree can attend to itself - that is why our project is > distributed. That certainly isn't how it has worked in the past. When I cut us over to GCC 2.95 and there was a build problem, people were certainly emailing me wondering when I was going to fix the build -- since it broke with a commit by me. > Heck, when you get the damn thing imported, I'll buy you a round (or six) > at a decent pub. Heck, you have been the hold up on this for 2 weeks. I've been trying to talk to you what we wanted to do about the src/contrib/gcc repo so I could import. -- -- David (obrien@FreeBSD.org) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message