Date: Tue, 6 Oct 2009 15:48:02 +0000 From: Masoom Shaikh <masoom.shaikh@gmail.com> To: Iain Hibbert <plunky@rya-online.net> Cc: freebsd-bluetooth@freebsd.org Subject: Re: bluetooth.h, c++ include error Message-ID: <b10011eb0910060848g498b11a2kb9faf75453e664d@mail.gmail.com> In-Reply-To: <1254763597.419838.805.nullmailer@galant.ukfsn.org> References: <b10011eb0910011142p480deee4j220ebb41623f58e0@mail.gmail.com> <b10011eb0910011232r13ddb42axd97a65b3cb025de9@mail.gmail.com> <b10011eb0910041042r7edd20afhf5ec42e652514b81@mail.gmail.com> <bb4a86c70910041126r3bfb7cc5w71281fb3b5f8ccd@mail.gmail.com> <b10011eb0910050958j49eed45diee0c36f3947f094@mail.gmail.com> <1254763597.419838.805.nullmailer@galant.ukfsn.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Oct 5, 2009 at 5:26 PM, Iain Hibbert <plunky@rya-online.net> wrote: > On Mon, 5 Oct 2009, Masoom Shaikh wrote: > > > what i am requesting is just variable name change ;-) my tree is at > > revision 197571, thus the patch i am presenting is also generated > > against it reject this if you want patch against latest revision > > > > renamed second argument of bt_devfilter() from 'new' to 'dfnew'. df for > > device filter to maintain uniformity renamed third argument from 'old' > > to 'dfold'. > > style(9) mentions that for kernel include files exposed to userland > (technically, this is always in userland but perhaps the same rules apply) > the prototype tag arguments should be made safe, eg starting with a _ > perhaps for much this reason.. > > so, my suggestion would be to use _new and _old etc.. > > iain > > (or, just don't use them, they are not especially required :) > > > > > so this shall work i just renamed bt_devfilter() variable names, because it was the one which caused trouble will someone commit this ? Index: bluetooth.h =================================================================== --- bluetooth.h (revision 197804) +++ bluetooth.h (working copy) @@ -163,8 +163,8 @@ int bt_devsend (int s, uint16_t opcode, void *param, size_t plen); ssize_t bt_devrecv (int s, void *buf, size_t size, time_t to); int bt_devreq (int s, struct bt_devreq *r, time_t to); -int bt_devfilter(int s, struct bt_devfilter const *new, - struct bt_devfilter *old); +int bt_devfilter(int s, struct bt_devfilter const *_new, + struct bt_devfilter *_old); void bt_devfilter_pkt_set(struct bt_devfilter *filter, uint8_t type); void bt_devfilter_pkt_clr(struct bt_devfilter *filter, uint8_t type); int bt_devfilter_pkt_tst(struct bt_devfilter const *filter, uint8_t type);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?b10011eb0910060848g498b11a2kb9faf75453e664d>