From owner-svn-src-all@freebsd.org Sat Apr 15 06:55:24 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 94A2AD3F9DD; Sat, 15 Apr 2017 06:55:24 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7822BE81; Sat, 15 Apr 2017 06:55:24 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id v3F6tN5P010504; Fri, 14 Apr 2017 23:55:23 -0700 (PDT) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id v3F6tMvg010503; Fri, 14 Apr 2017 23:55:23 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201704150655.v3F6tMvg010503@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r316953 - head/sbin/savecore In-Reply-To: <201704150653.v3F6r7hJ081000@repo.freebsd.org> To: Ngie Cooper Date: Fri, 14 Apr 2017 23:55:22 -0700 (PDT) CC: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 Apr 2017 06:55:24 -0000 > Author: ngie > Date: Sat Apr 15 06:53:07 2017 > New Revision: 316953 > URL: https://svnweb.freebsd.org/changeset/base/316953 > > Log: > Switch back to non-IEC units for 1024 bytes > > I was swayed a little too quickly when I saw the wiki page discussing > kB vs KiB. Switch back as none of the code in base openly uses > IEC units via humanize_number(3) (which was my next step), and there's > a large degree of dislike with IEC vs more SI-like units. > > MFC after: 7 weeks > Submitted by: jhb, rgrimes > Sponsored by: Dell EMC Isilon > > Modified: > head/sbin/savecore/savecore.c > > Modified: head/sbin/savecore/savecore.c > ============================================================================== > --- head/sbin/savecore/savecore.c Sat Apr 15 03:28:13 2017 (r316952) > +++ head/sbin/savecore/savecore.c Sat Apr 15 06:53:07 2017 (r316953) > @@ -322,7 +322,7 @@ check_space(const char *savedir, off_t d > if (available < needed) { > syslog(LOG_WARNING, > "no dump: not enough free space on device (need at least " > - "%jdKiB for dump; %jdKiB available; %jdKiB reserved)", > + "%jdkB for dump; %jdkB available; %jdkB reserved)", > (intmax_t)needed, > (intmax_t)available + minfree, > (intmax_t)minfree); Thank you! -- Rod Grimes rgrimes@freebsd.org