From owner-svn-ports-all@freebsd.org  Sat Mar 25 02:49:02 2017
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7D65ED1C6EA;
 Sat, 25 Mar 2017 02:49:02 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 5C4991626;
 Sat, 25 Mar 2017 02:49:02 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 7EF78364D; Sat, 25 Mar 2017 02:49:00 +0000 (UTC)
Date: Sat, 25 Mar 2017 02:49:00 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Kyle Evans <bsdports@kyle-evans.net>
Cc: Diane Bruce <db@freebsd.org>, svn-ports-head@freebsd.org,
 svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject: Re: svn commit: r436814 - in head/comms: . direwolf direwolf/files
Message-ID: <20170325024900.GC18367@FreeBSD.org>
References: <201703241401.v2OE1nwY023666@repo.freebsd.org>
 <20170325014740.GC54562@FreeBSD.org>
 <CACNAnaFhG=WufG3VP3TG6CZWf507X=OFWzif2YUm8==JDKEuGg@mail.gmail.com>
 <20170325023517.GA18367@FreeBSD.org>
 <CACNAnaGdOSmZY58oE6z8P2kHO6NaNUx4-geurbteH45bLe9f7w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CACNAnaGdOSmZY58oE6z8P2kHO6NaNUx4-geurbteH45bLe9f7w@mail.gmail.com>
User-Agent: Mutt/1.7.1 (2016-10-04)
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 25 Mar 2017 02:49:02 -0000

On Fri, Mar 24, 2017 at 09:39:15PM -0500, Kyle Evans wrote:
> On Fri, Mar 24, 2017 at 9:35 PM, Alexey Dokuchaev <danfe@freebsd.org> wrote:
> > Thanks, one more little thing before it can be committed.
> 
> Hah, jokes on you, there were two things I messed up! =)

;-)

> >> +MAKE_ENV+=   STAGEDIR=${STAGEDIR}
> >
> > You didn't run make -V MAKE_ARGS, did you? :-)
> 
> Oy, I actually didn't because all of the other directories I cared
> about were in MAKE_ENV, and I was looking for STAGEDIR specifically.
> 
> Attached is a revised patch, s/STAGEDIR/DESTDIR/ and the dw-start.sh
> script was getting installed with the wrong permissions because I
> overlooked the fact it's installed in the examples/ with a bunch of
> datafiles.

LGTM, but I'm sleepy and fainting away.  Let's let Diane to review
and handle it as it was their commit in the first place.

./danfe