Date: Thu, 14 Mar 2013 10:37:51 -0700 From: Jason Helfman <jgh@FreeBSD.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, Beech Rintoul <beech@freebsd.org>, "ports-committers@freebsd.org" <ports-committers@freebsd.org> Subject: Re: svn commit: r314117 - head/games/kye Message-ID: <CAMuy=%2Bg7Jj1N6Fo9YqoJsPngBEr_ajmThRo0uKWDq1U86UfpVg@mail.gmail.com> In-Reply-To: <20130314165712.GA8275@FreeBSD.org> References: <201303132159.r2DLx1QL092713@svn.freebsd.org> <20130314070455.GA42406@hatter> <20130314075330.GA94901@FreeBSD.org> <201303132359.22984.beech@freebsd.org> <20130314081701.GA6014@FreeBSD.org> <CAMuy=%2BhkQ%2BqieiwX97%2BC9jfAkGVOzrAwvh0cTeQ1Z1dYU0Scag@mail.gmail.com> <20130314165712.GA8275@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Mar 14, 2013 at 9:57 AM, Alexey Dokuchaev <danfe@freebsd.org> wrote:
> On Thu, Mar 14, 2013 at 08:30:06AM -0700, Jason Helfman wrote:
> > PORTDOCS make variable assignment is different then a PLIST_SUB. It also
> > depends how it is used in the Makefile. In this instance, they are both
> > used correctly.
>
> PORTDOCS were introduced precisely to be able to off-load pkg-plist for
> simple cases, like this one. I really do not understand what point are
> you trying to make here Jason, sorry. For me it looks that ${TMPPLIST}
> will now contain two copies of the docs, which upsets package deinstall.
>
> If you still believe you're being right here, can you please explain:
>
> - Why there are two instances of docs in .PLIST.mktmp, per simple grep?
> - Why would anyone what to record docs twice (in PORTDOCS and pkg-plist)?
> - Why do I see this:
>
> $ make deinstall
> ===> Switching to root credentials for 'deinstall' target
> Password:
> ===> Deinstalling for games/kye
> ===> Deinstalling py27-kye-1.0_3
> pkg_delete: file '/tmp/j/share/doc/kye/NEWS' doesn't exist
> pkg_delete: file '/tmp/j/share/doc/kye/README' doesn't exist
> pkg_delete: file '/tmp/j/share/doc/kye' doesn't exist
> pkg_delete: unable to completely remove directory '/tmp/j/share/doc/kye'
> pkg_delete: couldn't entirely delete package `py27-kye-1.0_3'
> (perhaps the packing list is incorrectly specified?)
> ===> Returning to user credentials
>
> Do you still disagree that PORTDOCS lines should be removed from pkg-plist
> in favor of PORTDOCS set in the Makefile?
>
> ./danfe
>
>
I completely agree with you, however since PLIST_SUB isn't doing anything
in the Makefile, nor the pkg-plist, I really don't see the use for it. For
some reason, the maintainer is using it, and I trusted that it had built
fine per committer.
I, myself, normally prefer:
PORTDOCS= *
And have nothing related to %%PORTDOCS%% in plist.
-jgh
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMuy=%2Bg7Jj1N6Fo9YqoJsPngBEr_ajmThRo0uKWDq1U86UfpVg>