From owner-freebsd-current@FreeBSD.ORG Tue Jan 11 15:03:31 2005 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B1D8F16A4CE for ; Tue, 11 Jan 2005 15:03:31 +0000 (GMT) Received: from mail3.speakeasy.net (mail3.speakeasy.net [216.254.0.203]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4BA1F43D5A for ; Tue, 11 Jan 2005 15:03:31 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: (qmail 21433 invoked from network); 11 Jan 2005 15:03:31 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 11 Jan 2005 15:03:27 -0000 Received: from [192.168.0.15] (osx.baldwin.cx [192.168.0.15]) (authenticated bits=0) by server.baldwin.cx (8.12.11/8.12.11) with ESMTP id j0BF2krb018296; Tue, 11 Jan 2005 10:02:46 -0500 (EST) (envelope-from jhb@FreeBSD.org) In-Reply-To: <41E02AD7.5000005@root.org> References: <20587818.1102626838092.JavaMail.tomcat@pne-ps4-sn1> <41DEED05.4040000@root.org> <41DF0839.6040700@telia.com> <200501071728.16828.jhb@FreeBSD.org> <41DF2BB3.60800@root.org> <41DF347E.6010305@telia.com> <41DF5159.1090106@root.org> <41DF5DEA.3030904@telia.com> <41DF9481.5030305@root.org> <41DFA2FF.0@telia.com> <41E02AD7.5000005@root.org> Mime-Version: 1.0 (Apple Message framework v619) Content-Type: text/plain; charset=US-ASCII; format=flowed Message-Id: Content-Transfer-Encoding: 7bit From: John Baldwin Date: Tue, 11 Jan 2005 10:02:45 -0500 To: Nate Lawson X-Mailer: Apple Mail (2.619) X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx cc: freebsd-current@FreeBSD.org Subject: Re: page fault panic in device_get_softc/acpi_pcib_route_interrupt X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Jan 2005 15:03:31 -0000 On Jan 8, 2005, at 1:47 PM, Nate Lawson wrote: > Pawel Worach wrote: >> Nate Lawson wrote: >> --- sys/dev/acpica/acpi_pcib.c 27 Dec 2004 05:36:47 -0000 1.53 >> +++ sys/dev/acpica/acpi_pcib.c 8 Jan 2005 09:05:57 -0000 >> @@ -249,11 +249,18 @@ >> /* >> * We have to find the source device (PCI interrupt link device). >> */ >> - if (ACPI_FAILURE(AcpiGetHandle(ACPI_ROOT_OBJECT, prt->Source, >> &lnkdev))) { >> + if (ACPI_FAILURE(AcpiGetHandle(acpi_get_handle(pcib), >> prt->Source, >> + &lnkdev))) { >> device_printf(pcib, "couldn't find PCI interrupt link device >> %s\n", >> prt->Source); >> goto out; >> } > > This change should not be committed. I think it's correct to use \ to > start the search since your _PRT contains relative references but the > links are under \. So, should I change the code to force-attach the devices to also use ACPI_ROOT_OBJECT for its lookup as well in prt_attach_devices()? -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org