From owner-freebsd-fs@FreeBSD.ORG Mon Jun 20 06:12:58 2011 Return-Path: Delivered-To: fs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 06CBC106564A for ; Mon, 20 Jun 2011 06:12:58 +0000 (UTC) (envelope-from mm@FreeBSD.org) Received: from mail.vx.sk (mail.vx.sk [IPv6:2a01:4f8:100:1043::3]) by mx1.freebsd.org (Postfix) with ESMTP id 95F1B8FC16 for ; Mon, 20 Jun 2011 06:12:57 +0000 (UTC) Received: from core.vx.sk (localhost [127.0.0.1]) by mail.vx.sk (Postfix) with ESMTP id C3840181D7C; Mon, 20 Jun 2011 08:12:56 +0200 (CEST) X-Virus-Scanned: amavisd-new at mail.vx.sk Received: from mail.vx.sk ([127.0.0.1]) by core.vx.sk (mail.vx.sk [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 30yMbWWY2ubR; Mon, 20 Jun 2011 08:12:51 +0200 (CEST) Received: from [10.9.8.1] (chello085216231078.chello.sk [85.216.231.78]) by mail.vx.sk (Postfix) with ESMTPSA id AA050181D5D; Mon, 20 Jun 2011 08:12:51 +0200 (CEST) Message-ID: <4DFEE4E3.2010509@FreeBSD.org> Date: Mon, 20 Jun 2011 08:12:51 +0200 From: Martin Matuska User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; sk; rv:1.8.1.23) Gecko/20090812 Lightning/0.9 Thunderbird/2.0.0.23 Mnenhy/0.7.5.0 MIME-Version: 1.0 To: "Justin T. Gibbs" References: <4DF7C406.1080903@scsiguy.com> In-Reply-To: <4DF7C406.1080903@scsiguy.com> X-Enigmail-Version: 1.1.2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: fs@FreeBSD.org Subject: Re: [CFR][ZFS] Show removed devices by GUID in zpool output. X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Jun 2011 06:12:58 -0000 I agree to this change, too. Dňa 14.06.2011 22:26, Justin T. Gibbs wrote / napísal(a): > The current behavior of zpool_vdev_name() is to report the vdev path > (e.g. /dev/da0) unless > a vdev has the ZPOOL_CONFIG_NOT_PRESENT attribute set. This attribute > is only set when > a vdev is not found during import/mount of a pool. The attached patch > also displays a vdev > by GUID if it cannot be opened post import or is marked removed (e.g. > via a GEOM orphan > event). > > The main motivation for this change is that vdev paths are not unique to > a physical leaf vdev. > It is easy to get into a situation where you need to "detach /dev/da0" > event though da0 is > an active member of the same pool in which a "previous da0" was once > removed. With > zpool_vdev_name() reporting the GUID, the user is equipped to provide an > unambiguous > command that represents their desired action. -- Martin Matuska FreeBSD committer http://blog.vx.sk