Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 10 Sep 2004 20:11:44 +0200
From:      Stefan =?iso-8859-1?Q?E=DFer?= <se@FreeBSD.org>
To:        Matthew Jacob <mjacob44@yahoo.com>
Cc:        Norikatsu Shigemura <nork@FreeBSD.org>
Subject:   Re: PANIC: sym(4) didn't MODULE_DEPEND cam(4).
Message-ID:  <20040910181144.GA4513@StefanEsser.FreeBSD.org>
In-Reply-To: <20040910175749.22388.qmail@web21430.mail.yahoo.com>
References:  <200409101717.i8AHHGWR044322@sakura.ninth-nine.com> <20040910175749.22388.qmail@web21430.mail.yahoo.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On 2004-09-10 10:57 -0700, Matthew Jacob <mjacob44@yahoo.com> wrote:
> 
> Committed- thanks!

How about adding a MODULE_DEPEND on PCI as well, as is common
practice in other PCI device drivers ?

Index: sym_hipd.c
===================================================================
RCS file: /home/ncvs/src/sys/dev/sym/sym_hipd.c,v
retrieving revision 1.49
diff -u -r1.49 sym_hipd.c
--- sym_hipd.c  10 Sep 2004 17:57:33 -0000      1.49
+++ sym_hipd.c  10 Sep 2004 18:08:57 -0000
@@ -8502,6 +8502,7 @@
 
 DRIVER_MODULE(sym, pci, sym_pci_driver, sym_devclass, 0, 0);
 MODULE_DEPEND(sym, cam, 1, 1, 1);
+MODULE_DEPEND(sym, pci, 1, 1, 1);
 
 
 static struct sym_pci_chip sym_pci_dev_table[] = {


Regards, STefan



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040910181144.GA4513>