Date: Thu, 14 May 2015 19:16:30 -0500 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Adam Weinberger <adamw@adamw.org> Cc: "Philip M. Gollucci" <pgollucci@p6m7g8.com>, "ports-committers@freebsd.org" <ports-committers@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org> Subject: Re: svn commit: r386285 - head/security/keychain Message-ID: <55553ADE.5070207@FreeBSD.org> In-Reply-To: <5554CB3B.9070807@FreeBSD.org> References: <201505140101.t4E11r9T031351@svn.freebsd.org> <08F806A7-3CD9-417A-BA4E-AF739E83B6A8@adamw.org> <CACM2dAaFL6F-=mbfODTRrR83L%2BGeLfxzcM16DoroP1shmP6NHQ@mail.gmail.com> <082DB80D-6385-4F4F-8A86-2DB4561E39E8@adamw.org> <5554C761.3060609@FreeBSD.org> <07ED759D-DFAC-44D0-A22B-1639EE3E0CB8@adamw.org> <5554C8A1.50200@FreeBSD.org> <317F946C-1F0E-4F8E-B121-6442CC82BCAA@adamw.org> <5554C918.8090305@FreeBSD.org> <5554CB3B.9070807@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --mD1rGQcSGj7AkjKb9JKbWvuLwVJXsp0UU Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 5/14/2015 11:20 AM, Bryan Drewery wrote: > On 5/14/2015 11:11 AM, Bryan Drewery wrote: >> On 5/14/2015 11:10 AM, Adam Weinberger wrote: >>>> On 14 May, 2015, at 10:09, Bryan Drewery <bdrewery@FreeBSD.org> wrot= e: >>>> >>>> On 5/14/2015 11:07 AM, Adam Weinberger wrote: >>>>>> On 14 May, 2015, at 10:03, Bryan Drewery <bdrewery@FreeBSD.org> wr= ote: >>>>>> >>>>>> On 5/14/2015 11:00 AM, Adam Weinberger wrote: >>>>>>>> On 13 May, 2015, at 21:20, Philip M. Gollucci <pgollucci@p6m7g8.= com> wrote: >>>>>>>> >>>>>>>> Then it needs an option not an if exists() >>>>>>> >>>>>>> Bryan, can you please consider reverting it, or giving me approva= l to revert it? It may fix the case when the port is built in poudriere w= ithout sshd in base, but it is a regression for everybody else. >>>>>>> >>>>>>> # Adam >>>>>>> >>>>>>> >>>>>> >>>>>> No. The way RUN_DEPENDS is supposed to work is what I said in the >>>>>> commit. These exists() checks are redundant and confuse the packag= e >>>>>> dependencies. >>>>>> >>>>>> How are you building? It's possible the tool you are using is >>>>>> incorrectly handling RUN_DEPENDS. >>>>> >>>>> Ah! I see. It's portmaster that's doing the misbehaving. The proble= m is that openssh-portable still shows up in run-depends-list, and so por= tmaster decides that it is going to install openssh-portable first. >>>>> >>>>> [root@apnoea /usr/ports/security/keychain] which ssh-agent >>>>> /usr/bin/ssh-agent >>>>> [root@apnoea /usr/ports/security/keychain] make run-depends-list >>>>> /usr/ports/security/openssh-portable >>>>> /usr/ports/shells/bash >>>>> >>>> >>>> Ok. I'll look at portmaster and try to fix it now. We really need th= ese >>>> exists() to go away; it causes rebuilds on the package cluster for n= o >>>> reason. This specific case is not one, but we need them to generally= go >>>> away. >>> >>> Sorry about the noise, Bryan. >>> >> >> It's not noise! There's 2 bugs here. Portmaster installs and Poudriere= >> builds. Both need to be fixed :) >> >> >=20 > Portupgrade also incorrectly installs. >=20 At leat portupgrade-devel should now do the right things. Portmaster is next. --=20 Regards, Bryan Drewery --mD1rGQcSGj7AkjKb9JKbWvuLwVJXsp0UU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJVVTreAAoJEDXXcbtuRpfP9bwH/RSuBsRMlUZiNr2DnDHCY9Jw wyRkHlXXQHtWs9GtJmvkREaZvYMafnonBkjHlaGYs/d6cM0xj7DjHrS9/e3HS8mQ rPcsXlNu1ZkjBUKrSr9CuZtcT65YBlAQpRRYmB1Xre3ELtqsLSDevKDMAnCPijch zVya8U3TRA5KEuyfcIBmoBMGPoU4BWvHj8LfpcAGvOEBpIR99DMi7R8+lCkHGoB3 rpZi1TJ6fi/V3Ay6iZfLNzmYt+Cop9CIxlG0G+wO3k3w6cQdLCBVqP5vz7D32F3F Qb719MXNrSKeMD/H4ETBuPWeZULNq5awWr31OVJGhpT6an4d9YCg/1tU/vX5KUA= =z1r4 -----END PGP SIGNATURE----- --mD1rGQcSGj7AkjKb9JKbWvuLwVJXsp0UU--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?55553ADE.5070207>