From owner-freebsd-bugs@freebsd.org Thu Jun 30 15:37:31 2016 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BE4CCB8633C for ; Thu, 30 Jun 2016 15:37:31 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mx1.sbone.de (bird.sbone.de [46.4.1.90]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "mx1.sbone.de", Issuer "SBone.DE" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 806122DDA for ; Thu, 30 Jun 2016 15:37:30 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:31::2013:587]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.sbone.de (Postfix) with ESMTPS id 37AC125D3A6D; Thu, 30 Jun 2016 15:37:27 +0000 (UTC) Received: from content-filter.sbone.de (content-filter.sbone.de [IPv6:fde9:577b:c1a9:31::2013:2742]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id 57B4AD1F892; Thu, 30 Jun 2016 15:37:26 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:31::2013:587]) by content-filter.sbone.de (content-filter.sbone.de [fde9:577b:c1a9:31::2013:2742]) (amavisd-new, port 10024) with ESMTP id 26rtFt4_WZFT; Thu, 30 Jun 2016 15:37:24 +0000 (UTC) Received: from nv.sbone.de (nv.sbone.de [IPv6:fde9:577b:c1a9:31::2013:138]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id 7914BC7BC72; Thu, 30 Jun 2016 15:37:24 +0000 (UTC) Date: Thu, 30 Jun 2016 15:37:23 +0000 (UTC) From: "Bjoern A. Zeeb" To: freebsd-bugs@FreeBSD.org cc: olevole@olevole.ru Subject: Re: [Bug 210724] panic on vnet destroy on recent FreeBSD 11-ALPHA5: vnet or rw_wlock_hard related In-Reply-To: Message-ID: References: X-OpenPGP-Key-Id: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jun 2016 15:37:31 -0000 On Thu, 30 Jun 2016, bugzilla-noreply@freebsd.org wrote: > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=210724 > > Bug ID: 210724 > Summary: panic on vnet destroy on recent FreeBSD 11-ALPHA5: > vnet or rw_wlock_hard related > Product: Base System > Version: 11.0-CURRENT > Hardware: Any > OS: Any > Status: New > Severity: Affects Only Me > Priority: --- > Component: kern > Assignee: freebsd-bugs@FreeBSD.org > Reporter: olevole@olevole.ru > > FreeBSD 11.0-ALPHA5 r302206 > > When destroy vnet-based interfaces, FreeBSD panic with Fatal trap 12: Hi, I cannot login to bugzilla currently from here, but could you try: Index: sys/netpfil/ipfw/ip_fw_nat.c =================================================================== --- sys/netpfil/ipfw/ip_fw_nat.c (revision 302298) +++ sys/netpfil/ipfw/ip_fw_nat.c (working copy) @@ -104,6 +104,10 @@ ifaddr_change(void *arg __unused, struct ifnet *if KASSERT(curvnet == ifp->if_vnet, ("curvnet(%p) differs from iface vnet(%p)", curvnet, ifp->if_vnet)); + + if (V_ipfw_vnet_ready == 0 || V_ipfw_nat_ready == 0) + return; + chain = &V_layer3_chain; IPFW_UH_WLOCK(chain); /* Check every nat entry... */ @@ -1145,12 +1149,12 @@ vnet_ipfw_nat_uninit(const void *arg __unused) chain = &V_layer3_chain; IPFW_WLOCK(chain); + V_ipfw_nat_ready = 0; LIST_FOREACH_SAFE(ptr, &chain->nat, _next, ptr_temp) { LIST_REMOVE(ptr, _next); free_nat_instance(ptr); } flush_nat_ptrs(chain, -1 /* flush all */); - V_ipfw_nat_ready = 0; IPFW_WUNLOCK(chain); return (0); } -- Bjoern A. Zeeb r15:7