From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Jun 4 15:30:20 2012 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 9B8DF10656B0 for ; Mon, 4 Jun 2012 15:30:20 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 97A1A8FC18 for ; Mon, 4 Jun 2012 15:30:16 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q54FUG0O020901 for ; Mon, 4 Jun 2012 15:30:16 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q54FUGQX020898; Mon, 4 Jun 2012 15:30:16 GMT (envelope-from gnats) Date: Mon, 4 Jun 2012 15:30:16 GMT Message-Id: <201206041530.q54FUGQX020898@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org From: Greg Lewis Cc: Subject: Re: ports/168559: Updated lang/clojure to version 1.4.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Greg Lewis List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Jun 2012 15:30:20 -0000 The following reply was made to PR ports/168559; it has been noted by GNATS. From: Greg Lewis To: Michael Scheidell Cc: freebsd-ports-bugs@freebsd.org, bug-followup@freebsd.org Subject: Re: ports/168559: Updated lang/clojure to version 1.4.0 Date: Mon, 4 Jun 2012 08:29:46 -0700 On Mon, Jun 04, 2012 at 10:40:13AM +0000, Michael Scheidell wrote: > The following reply was made to PR ports/168559; it has been noted by GNATS. > > From: Michael Scheidell > To: > Cc: > Subject: Fwd: Re: ports/168559: Updated lang/clojure to version 1.4.0 > Date: Mon, 4 Jun 2012 06:39:15 -0400 > > diff -ruN clojure.old/Makefile clojure/Makefile > --- clojure.old/Makefile 2012-06-04 06:18:16.000000000 +0200 > +++ clojure/Makefile 2012-06-04 06:18:58.000000000 +0200 > @@ -7,11 +7,11 @@ > # > > PORTNAME= clojure > -PORTVERSION= 1.2.0 > +PORTVERSION= 1.4.0 > PORTREVISION= 1 PORTREVISION should be removed. > PORTEPOCH= 2 > CATEGORIES= lang lisp java > -MASTER_SITES= http://cloud.github.com/downloads/clojure/clojure/ > +MASTER_SITES= http://repo1.maven.org/maven2/org/clojure/clojure/1.4.0/ It would make sense to embed ${PORTVERSION} here instead of hardcoding 1.4.0 everywhere. > MAINTAINER= peter.schuller@infidyne.com > COMMENT= A dynamic programming language for the JVM > @@ -24,7 +24,7 @@ > OPTIONS= JLINE "Enable jline support for the REPL" on > > PLIST_FILES= bin/clojure \ > - %%JAVAJARDIR%%/clojure-1.2.0.jar > + %%JAVAJARDIR%%/clojure-1.4.0.jar Same comment here. > .include > > @@ -37,6 +37,6 @@ > > do-install: > @${INSTALL_SCRIPT} ${WRKDIR}/clojure-bin ${PREFIX}/bin/clojure > - @${INSTALL_DATA} ${WRKSRC}/clojure.jar ${JAVAJARDIR}/clojure-1.2.0.jar > + @${INSTALL_DATA} ${WRKSRC}/clojure-1.4.0.jar ${JAVAJARDIR}/clojure-1.4.0.jar And again here (all of which would make the next upgrade easier). > .include > diff -ruN clojure.old/distinfo clojure/distinfo > --- clojure.old/distinfo 2012-06-04 06:18:16.000000000 +0200 > +++ clojure/distinfo 2012-06-04 06:18:58.000000000 +0200 > @@ -1,2 +1,2 @@ > -SHA256 (clojure-1.2.0.zip) = 1334773cb13793bdc0588de0fe5b5aec602bb98ca84858d7374b4e063864d207 > -SIZE (clojure-1.2.0.zip) = 3586231 > +SHA256 (clojure-1.4.0.zip) = 27a5a151d5cc1bc3e52dff47c66111e637fefeb42d9bedfa1284a1a31d080171 > +SIZE (clojure-1.4.0.zip) = 4553941 > diff -ruN clojure.old/files/clojure-bin.in clojure/files/clojure-bin.in > --- clojure.old/files/clojure-bin.in 2012-06-04 06:18:16.000000000 +0200 > +++ clojure/files/clojure-bin.in 2012-06-04 06:18:58.000000000 +0200 > @@ -2,4 +2,4 @@ > # > # $FreeBSD: ports/lang/clojure/files/clojure-bin.in,v 1.8 2011/07/21 05:02:48 linimon Exp $ > > -JAVA_VERSION="%%JAVA_VERSION%%" "%%LOCALBASE%%/bin/java" -cp "%%JAVAJARDIR%%/jline.jar:%%JAVAJARDIR%%/clojure-1.2.0.jar:%%JAVAJARDIR%%/clojure-contrib-1.2.0.jar:%%JAVAJARDIR%%/swank-clojure-1.2.1.jar:$CLASSPATH" %%CLOJURE_JLINE_RUNNER%% clojure.main "$@" > +JAVA_VERSION="%%JAVA_VERSION%%" "%%LOCALBASE%%/bin/java" -cp "%%JAVAJARDIR%%/jline.jar:%%JAVAJARDIR%%/clojure-1.4.0.jar:%%JAVAJARDIR%%/swank-clojure-1.4.2.jar:$CLASSPATH" %%CLOJURE_JLINE_RUNNER%% clojure.main "$@" -- Greg Lewis Email : glewis@eyesbeyond.com Eyes Beyond Web : http://www.eyesbeyond.com Information Technology FreeBSD : glewis@FreeBSD.org