From owner-svn-ports-all@freebsd.org  Sat May 20 03:43:50 2017
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8D36DD75F7E;
 Sat, 20 May 2017 03:43:50 +0000 (UTC) (envelope-from adamw@adamw.org)
Received: from apnoea.adamw.org (apnoea.adamw.org [104.225.5.94])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "apnoea.adamw.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id F0C8C16AC;
 Sat, 20 May 2017 03:43:49 +0000 (UTC) (envelope-from adamw@adamw.org)
Received: by apnoea.adamw.org (OpenSMTPD) with ESMTPSA id 0853ec1b
 TLS version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO;
 Fri, 19 May 2017 21:43:47 -0600 (MDT)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: svn commit: r441282 - in head: . security security/acme.sh
From: Adam Weinberger <adamw@adamw.org>
In-Reply-To: <201705200227.v4K2RjjG055940@repo.freebsd.org>
Date: Fri, 19 May 2017 21:43:46 -0600
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <989C2BB0-AC4E-4C76-AB15-9F616A6EF392@adamw.org>
References: <201705200227.v4K2RjjG055940@repo.freebsd.org>
To: Dan Langille <dvl@FreeBSD.org>
X-Mailer: Apple Mail (2.3273)
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 20 May 2017 03:43:50 -0000

> On 19 May, 2017, at 20:27, Dan Langille <dvl@FreeBSD.org> wrote:
>=20
> Author: dvl
> Date: Sat May 20 02:27:45 2017
> New Revision: 441282
> URL: https://svnweb.freebsd.org/changeset/ports/441282
>=20
> Log:
>  A pure Unix shell script implementing ACME client protocol
>=20
>  Differential Revision: https://reviews.freebsd.org/D10308
>=20
> Added:
>  head/security/acme.sh/
>  head/security/acme.sh/Makefile   (contents, props changed)
>  head/security/acme.sh/distinfo   (contents, props changed)
>  head/security/acme.sh/pkg-descr   (contents, props changed)
> Modified:
>  head/GIDs
>  head/UIDs
>  head/security/Makefile
>=20
>=20
> +RUN_DEPENDS=3D	curl:ftp/curl
> +
> +OPTIONS_DEFINE=3D	CURL DOCS WGET
> +OPTIONS_DEFAULT=3D	CURL
> +CURL_DESC=3D	Add ftp/curl as a run-time dependency
> +WGET_DESC=3D	Add ftp/wget as a run-time dependency
> +
> +CURL_RUN_DEPENDS=3D	curl:ftp/curl
> +WGET_RUN_DEPENDS=3D	wget:ftp/wget

Hi Dan,

You have curl as a mandatory and optional dependency, which effectively =
makes curl mandatory. I think you want to use OPTIONS_SINGLE or =
OPTIONS_MULTI here, to make it an actual choice between the two of them.

Also the descriptions are a bit strange. I mean, it does add them as a =
dependency, but I think an end-user would be more concerned with what =
curl or wget does for acme.sh, no?

# Adam


--=20
Adam Weinberger
adamw@adamw.org
https://www.adamw.org