From owner-freebsd-ports@FreeBSD.ORG  Thu Jul  9 13:00:45 2009
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 46C001065688;
	Thu,  9 Jul 2009 13:00:45 +0000 (UTC)
	(envelope-from smcafee@collaborativefusion.com)
Received: from mx00.pub.collaborativefusion.com
	(mx00.pub.collaborativefusion.com [206.210.89.199])
	by mx1.freebsd.org (Postfix) with ESMTP id EC14F8FC1E;
	Thu,  9 Jul 2009 13:00:44 +0000 (UTC)
	(envelope-from smcafee@collaborativefusion.com)
Received: from [192.168.2.163] (icepick.ws.pitbpa0.priv.collaborativefusion.com
	[192.168.2.163])
	(AUTH: LOGIN smcafee, SSL: TLSv1/SSLv3,256bits,AES256-SHA)
	by wingspan with esmtp; Thu, 09 Jul 2009 08:50:41 -0400
	id 00056407.000000004A55E7A1.0000817F
Message-ID: <4A55E7A1.3020101@collaborativefusion.com>
Date: Thu, 09 Jul 2009 08:50:41 -0400
From: Sean McAfee <smcafee@collaborativefusion.com>
User-Agent: Thunderbird 2.0.0.21 (X11/20090404)
MIME-Version: 1.0
References: <20090708192122.GI55190@deviant.kiev.zoral.com.ua>
In-Reply-To: <20090708192122.GI55190@deviant.kiev.zoral.com.ua>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: ports@freebsd.org, girgen@freebsd.org
Subject: Re: postgresql-contrib 8.4.0
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Jul 2009 13:00:45 -0000

Thanks for fixing this, but I think that eliminating the ability to use 
a feature is just as unacceptable.  Something like the following would 
enable these as options (I wasn't able to get a conditional CONFLICTS 
working):

--- Makefile	2009-07-09 12:49:14.000000000 +0000
+++ Makefile.orig	2009-07-09 12:21:25.000000000 +0000
@@ -39,20 +39,9 @@
  PKGMESSAGE=	${.CURDIR}/pkg-message

  .if ${PGSQL_VER} > 83
-OPTIONS+=       XML "XML/XSLT support" on
-OPTIONS+=       UUID "UUID support (conflicts with e2fsprogs-libuuid)" on
-
-.  if ${PGSQL_VER} > 83 && defined(WITH_XML)
  CONFIGURE_ARGS+=	--with-libxslt --with-libxml
-LIB_DEPENDS+=		xslt.2:${PORTSDIR}/textproc/libxslt 
xml2.5:${PORTSDIR}/textproc/libxml2
-.  endif
-
-.  if ${PGSQL_VER} > 83 && defined(WITH_UUID)
-CONFIGURE_ARGS+=	--with-ossp-uuid
-BUILD_DEPENDS+= 
${LOCALBASE}/bin/uuid-config:${PORTSDIR}/misc/ossp-uuid
-.  endif
-
-.endif # PGSQL > 83
+LIB_DEPENDS=		xslt.2:${PORTSDIR}/textproc/libxslt 
xml2.5:${PORTSDIR}/textproc/libxml2
+.endif

  post-install:
  .if ${PGSQL_VER} < 81


-- 
Sean McAfee
System Engineer