Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 20 Sep 2002 17:12:48 +0200
From:      Poul-Henning Kamp <phk@critter.freebsd.dk>
To:        Darren Reed <darrenr@reed.wattle.id.au>
Cc:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/kern uipc_mbuf.c 
Message-ID:  <17014.1032534768@critter.freebsd.dk>
In-Reply-To: Your message of "Sat, 21 Sep 2002 01:00:02 %2B1000." <200209201500.BAA25430@avalon.reed.wattle.id.au> 

next in thread | previous in thread | raw e-mail | index | archive | help
In message <200209201500.BAA25430@avalon.reed.wattle.id.au>, Darren Reed writes
:
>>From Poul-Henning Kamp :
>> In some mail, Julian Elischer writes:
>> >
>> >  Modified files:
>> >    sys/kern             uipc_mbuf.c
>> >  Log:
>> >  While well intentionned the check to see it there is a packet
>> >  header and return that length, was misguided.
>> >
>> >  The check itself didn't take into account the fact that the
>> >  mbuf pointer pased in may be null, and the function is
>> >  defined specifically for cases where the caller knows what it wants.
>> >  Rather than fix the check I'm removing it as phk suggested.
>>
>> Not to mention that it failed to perform the other half of m_lenght()'s
>> job:  return a pointer to the last mbuf in the chain.
>
>Well, what is the purpose of m_length() ?
>
>Is there a comment supplied with it that says what it is meant to do ?
>Or meant to provide when it exits ?

man 9 mbuf  :-)

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?17014.1032534768>