From owner-cvs-all Fri Sep 20 8:12:57 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8833B37B401; Fri, 20 Sep 2002 08:12:56 -0700 (PDT) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id C383A43E3B; Fri, 20 Sep 2002 08:12:55 -0700 (PDT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.6/8.12.6) with ESMTP id g8KFCm4v017015; Fri, 20 Sep 2002 17:12:50 +0200 (CEST) (envelope-from phk@critter.freebsd.dk) To: Darren Reed Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern uipc_mbuf.c In-Reply-To: Your message of "Sat, 21 Sep 2002 01:00:02 +1000." <200209201500.BAA25430@avalon.reed.wattle.id.au> Date: Fri, 20 Sep 2002 17:12:48 +0200 Message-ID: <17014.1032534768@critter.freebsd.dk> From: Poul-Henning Kamp Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message <200209201500.BAA25430@avalon.reed.wattle.id.au>, Darren Reed writes : >>From Poul-Henning Kamp : >> In some mail, Julian Elischer writes: >> > >> > Modified files: >> > sys/kern uipc_mbuf.c >> > Log: >> > While well intentionned the check to see it there is a packet >> > header and return that length, was misguided. >> > >> > The check itself didn't take into account the fact that the >> > mbuf pointer pased in may be null, and the function is >> > defined specifically for cases where the caller knows what it wants. >> > Rather than fix the check I'm removing it as phk suggested. >> >> Not to mention that it failed to perform the other half of m_lenght()'s >> job: return a pointer to the last mbuf in the chain. > >Well, what is the purpose of m_length() ? > >Is there a comment supplied with it that says what it is meant to do ? >Or meant to provide when it exits ? man 9 mbuf :-) -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message