From owner-svn-src-head@FreeBSD.ORG  Tue Oct 11 13:46:27 2011
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 32DE1106566C;
	Tue, 11 Oct 2011 13:46:27 +0000 (UTC)
	(envelope-from SRS0=YiYk=42=FreeBSD.org=brueffer@srs.kundenserver.de)
Received: from moutng.kundenserver.de (moutng.kundenserver.de
	[212.227.126.187])
	by mx1.freebsd.org (Postfix) with ESMTP id B41E58FC13;
	Tue, 11 Oct 2011 13:46:26 +0000 (UTC)
Received: from hd5b90bea.sedadby.dyn.perspektivbredband.net
	(hd5b90bea.sedadby.dyn.perspektivbredband.net [213.185.11.234])
	by mrelayeu.kundenserver.de (node=mreu2) with ESMTP (Nemesis)
	id 0MYa6I-1Ra9Xz3HgQ-00Usg8; Tue, 11 Oct 2011 15:33:50 +0200
Message-ID: <4E9445BC.3020205@FreeBSD.org>
Date: Tue, 11 Oct 2011 15:33:48 +0200
From: Christian Brueffer <brueffer@FreeBSD.org>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6;
	rv:7.0.1) Gecko/20110929 Thunderbird/7.0.1
MIME-Version: 1.0
To: Giovanni Trematerra <giovanni.trematerra@gmail.com>
References: <201110111032.p9BAWNpw011158@svn.freebsd.org>
	<CACfq091nqG9wOoiOKNmdKfwBuBeyFUff7kUFXNEKqyfWAp6p+w@mail.gmail.com>
In-Reply-To: <CACfq091nqG9wOoiOKNmdKfwBuBeyFUff7kUFXNEKqyfWAp6p+w@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Provags-ID: V02:K0:HRTjXtaUWGu3Ycw+0J8COGc0EDqH+YMLB9dCkZX30rh
	TkTJsdsNkHRolrHYjkpvJlohzk+Q4AON85nNAbBwofBQk1tYIi
	ymQa4I7hM2WrXaTRsCxCZ0Cz6D1ZROZWIzh2oS34U4JOy8nx4V
	4P8JdtjOStmZAU9npqvKwG/0dYNHcHAsqSa2D/dyU5tFQabPGa
	3xLJMFFE9HVG9PaTxnjGEILp3Gs20JuL4k8JX5dE6AkKWMzfrq
	uui1INpWjf+TliA1shi3xSjSHYqgGyIv6kTQLPmVdv/y7mnhKO
	gYhKhfHhOavc+ln5PXABEpk1pVOqwURODJDb4Vu03yKAEFOsnb
	K/MlrmVoBYJ18NXtrFUqqDcLkg8886VLeRdSRiHOJPIdD7K77J
	r396twKrSbRqlquzwLq/gr/NVOWHAWRVM8=
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r226247 - head/sys/compat/linux
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 11 Oct 2011 13:46:27 -0000

On 10/11/11 13:26 , Giovanni Trematerra wrote:
> On Tue, Oct 11, 2011 at 12:32 PM, Christian Brueffer
> <brueffer@freebsd.org>  wrote:
>> Author: brueffer
>> Date: Tue Oct 11 10:32:23 2011
>> New Revision: 226247
>> URL: http://svn.freebsd.org/changeset/base/226247
>>
>> Log:
>>   Properly free linux_gidset in case of an error.
>>
>>   CID:          4136
>>   Found with:   Coverity Prevent(tm)
>>   MFC after:    1 week
>>
>> Modified:
>>   head/sys/compat/linux/linux_uid16.c
>>
>> Modified: head/sys/compat/linux/linux_uid16.c
>> ==============================================================================
>> --- head/sys/compat/linux/linux_uid16.c Tue Oct 11 07:46:45 2011        (r226246)
>> +++ head/sys/compat/linux/linux_uid16.c Tue Oct 11 10:32:23 2011        (r226247)
>> @@ -114,6 +114,7 @@ linux_setgroups16(struct thread *td, str
>>         linux_gidset = malloc(ngrp * sizeof(*linux_gidset), M_TEMP, M_WAITOK);
>>         error = copyin(args->gidset, linux_gidset, ngrp * sizeof(l_gid16_t));
>>         if (error)
>> +               free(linux_gidset, M_TEMP);
>>                 return (error);
>>         newcred = crget();
>>         p = td->td_proc;
>
> Did you miss { } ?
>

Gah, one of those things not cought by compile-testing.

Fixing it now, thanks!

Christian