From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Dec 25 21:00:23 2011 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6DCDD1065672 for ; Sun, 25 Dec 2011 21:00:23 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 1E6F08FC19 for ; Sun, 25 Dec 2011 21:00:23 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id pBPL0M5M003101 for ; Sun, 25 Dec 2011 21:00:22 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id pBPL0MvJ003100; Sun, 25 Dec 2011 21:00:22 GMT (envelope-from gnats) Resent-Date: Sun, 25 Dec 2011 21:00:22 GMT Resent-Message-Id: <201112252100.pBPL0MvJ003100@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Jan Beich Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DBDB9106564A for ; Sun, 25 Dec 2011 20:59:05 +0000 (UTC) (envelope-from jbeich@tormail.net) Received: from server2.hudsonvalleyhost.com (server2.hudsonvalleyhost.com [66.7.195.77]) by mx1.freebsd.org (Postfix) with ESMTP id 944668FC13 for ; Sun, 25 Dec 2011 20:59:04 +0000 (UTC) Received: from exit2.ipredator.se ([93.182.132.103]:60376 helo=internal.tormail.net) by server2.hudsonvalleyhost.com with esmtpsa (TLSv1:RC4-SHA:128) (Exim 4.69) (envelope-from ) id 1Rev9s-0014ei-Cm for FreeBSD-gnats-submit@freebsd.org; Sun, 25 Dec 2011 15:59:04 -0500 Received: from jbeich by internal.tormail.net with local (Exim 4.63) (envelope-from ) id 1Rev9O-000L7K-Dk for FreeBSD-gnats-submit@freebsd.org; Sun, 25 Dec 2011 20:58:35 +0000 Message-Id: <1Rev9O-000L7K-Dk@internal.tormail.net> Date: Mon, 26 Dec 2011 04:56:27 +0800 From: Jan Beich To: FreeBSD-gnats-submit@FreeBSD.org Cc: Subject: ports/163617: ports-mgmt/portlint: has no clue about dual/multi license defines X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Dec 2011 21:00:23 -0000 >Number: 163617 >Category: ports >Synopsis: ports-mgmt/portlint: has no clue about dual/multi license defines >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Dec 25 21:00:22 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Jan Beich >Release: FreeBSD 10.0-CURRENT amd64 >Organization: >Environment: >Description: While portlint understands "dual" and "multi" keywords for LICENSE it fails to recognize expanded defines required by them. As grouping by newlines seems like a readability improvement when many licenses are defined portlint should still check the correct order. >How-To-Repeat: LICENSE = FOO BAR LICENSE_COMB = multi LICENSE_PERMS_FOO = ${_LICENSE_PERMS_DEFAULT} LICENSE_PERMS_BAR = ${_LICENSE_PERMS_DEFAULT} LICENSE_TEXT_FOO = blah foo LICENSE_TEXT_BAR = blah bar LICENSE_NAME_FOO = foo license LICENSE_NAME_BAR = bar license $ portlint FATAL: Makefile: extra item "LICENSE_PERMS_FOO " placed in the LICENSE section. FATAL: Makefile: extra item "LICENSE_PERMS_BAR " placed in the LICENSE section. FATAL: Makefile: extra item "LICENSE_TEXT_FOO " placed in the LICENSE section. FATAL: Makefile: extra item "LICENSE_TEXT_BAR " placed in the LICENSE section. FATAL: Makefile: extra item "LICENSE_NAME_FOO" placed in the LICENSE section. FATAL: Makefile: extra item "LICENSE_NAME_BAR" placed in the LICENSE section. 6 fatal errors and 0 warnings found. Exit 6 # with a newline after LICENSE_COMB $ portlint looks fine. # after retrofitting into "single" type $ portlint FATAL: Makefile: LICENSE_TEXT appears out-of-order. FATAL: Makefile: LICENSE_NAME appears out-of-order. FATAL: Makefile: order must be LICENSE/LICENSE_COMB/LICENSE_GROUPS/LICENSE_NAME/LICENSE_TEXT/LICENSE_FILE/LICENSE_PERMS. 3 fatal errors and 0 warnings found. Exit 3 >Fix: >Release-Note: >Audit-Trail: >Unformatted: