Date: Sat, 10 Jun 2017 23:16:47 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Mathieu Arnold <mat@FreeBSD.org> Cc: Mark Felder <feld@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-branches@freebsd.org, portmgr@FreeBSD.org Subject: Re: svn commit: r443039 - branches/2017Q2 Message-ID: <20170610231647.GA99407@FreeBSD.org> In-Reply-To: <26f1138a-5b9d-1817-2ddc-a5f876df75df@FreeBSD.org> References: <201706091946.v59JkB4D050200@repo.freebsd.org> <1497037780.167039.1004506896.6EE77BCC@webmail.messagingengine.com> <26f1138a-5b9d-1817-2ddc-a5f876df75df@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Jun 10, 2017 at 11:51:15PM +0200, Mathieu Arnold wrote: > Le 09/06/2017 ?? 21:49, Mark Felder a ??crit : > > This was a no-op and was not supposed to be committed. I accidentally > > hit "yes" but did not fill in an "Approved by:" line and it allowed the > > commit anyway, so I believe the pre-commit hook is broken at the moment. > > The pre-commit hook is working just fine, the thing is, you *are* a > member of portmgr, so you get the "I'm god" treatment, and subversion > goes along with it :-) Shouldn't it still require an explicit "(implicit)" line in this case? ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170610231647.GA99407>