From owner-svn-ports-all@FreeBSD.ORG  Thu Apr  2 06:31:56 2015
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id 254D0372; Thu,  2 Apr 2015 06:31:56 +0000 (UTC)
Date: Thu, 2 Apr 2015 06:31:56 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Bartek Rutkowski <robak@FreeBSD.org>
Subject: Re: svn commit: r382946 - head/games/gottet
Message-ID: <20150402063156.GC89620@FreeBSD.org>
References: <201504011953.t31JrrBR069299@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201504011953.t31JrrBR069299@svn.freebsd.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Apr 2015 06:31:56 -0000

On Wed, Apr 01, 2015 at 07:53:53PM +0000, Bartek Rutkowski wrote:
> New Revision: 382946
> URL: https://svnweb.freebsd.org/changeset/ports/382946
> 
> Log:
>   games/gottet: update 1.0.6 -> 1.1.1
>   - Switch to QT5

Few observations, if you allow me:

> [...]
> -PORTDOCS=	CREDITS ChangeLog NEWS README

Why was this line removed?  What was wrong with PORTDOCS?  It was not
mentioned in the log.

> +INSTALLS_ICONS=	yes

As recently pointed out by kwm@ on x11-list, INSTALLS_ICONS is Gtk+-only
and thus should not be used for Qt-ports.

> -	${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/|} ${STAGEDIR}${DOCSDIR}
> +	(cd ${WRKSRC} && ${INSTALL_DATA} CREDITS ChangeLog NEWS README \
> +		${STAGEDIR}${DOCSDIR})

Gratuitous change: pointless (non-functional), cryptic, two commands and
two lines instead of one, has nothing to do with what commit log taks about,
pessimizes "svn blame", etc.  In short: it should not have been committed.

./danfe