Date: Mon, 08 Apr 2019 09:28:45 +0100 From: Chris Rees <crees@FreeBSD.org> To: Oliver Pinter <oliver.pinter@hardenedbsd.org> Cc: Warner Losh <imp@bsdimp.com>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org>, Warner Losh <imp@freebsd.org>, owner-svn-src-all@freebsd.org Subject: Re: svn commit: r346018 - head/sys/conf Message-ID: <839b79cfabfc63d0077895575f317570@FreeBSD.org> In-Reply-To: <CAPQ4ffvb0gL=WiaVDi9MzYUp6JM5%2BKVuaRXbqikmH0c-OK8XGA@mail.gmail.com> References: <201904071839.x37IduPO002007@repo.freebsd.org> <CAPQ4ffuqxQvszqxvpBDt_D0no_k8OS-5xDrgccPJCE5RfxsLBg@mail.gmail.com> <CANCZdfqHoQNOwFiLhMGfUZdCRvAv_OdMt%2Bjua_n%2B4ax759y5Gg@mail.gmail.com> <CAPQ4ffvb0gL=WiaVDi9MzYUp6JM5%2BKVuaRXbqikmH0c-OK8XGA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2019-04-08 08:57, Oliver Pinter wrote: > On Monday, April 8, 2019, Warner Losh <imp@bsdimp.com> wrote: > >> >> >> On Sun, Apr 7, 2019, 3:16 PM Oliver Pinter >> <oliver.pinter@hardenedbsd.org> >> wrote: >> >>> Please revert this patch. If I'm not wrong, this will break the >>> freebsd-version command's generation or output. >>> >> >> You are going to need to be a lot more specific about this. It makes >> no >> sense to me at all how any of this could break that. The code is >> identical >> logically and produces the same result. >> > > Now I double checked, it may work, but I remembered to this "black > magic" : > https://github.com/freebsd/freebsd/blob/master/bin/freebsd-version/Makefile > Given it will evaluate to BRANCH=${BRANCH_OVERRIDE:-CURRENT} which unless you set BRANCH_OVERRIDE, then it will still work no problem. Chris -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?839b79cfabfc63d0077895575f317570>