From owner-freebsd-bugs@freebsd.org Thu Sep 29 16:05:35 2016 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 52E9AC010E3 for ; Thu, 29 Sep 2016 16:05:35 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 3855BAED for ; Thu, 29 Sep 2016 16:05:35 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u8TG5ZAO027950 for ; Thu, 29 Sep 2016 16:05:35 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 213092] tar(1) continues to run and error after non-existent file Date: Thu, 29 Sep 2016 16:05:35 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: sega01@go-beyond.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter cc Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Sep 2016 16:05:35 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D213092 Bug ID: 213092 Summary: tar(1) continues to run and error after non-existent file Product: Base System Version: CURRENT Hardware: amd64 OS: Any Status: New Severity: Affects Only Me Priority: --- Component: bin Assignee: freebsd-bugs@FreeBSD.org Reporter: sega01@go-beyond.org CC: freebsd-amd64@FreeBSD.org CC: freebsd-amd64@FreeBSD.org I suspect this fix is what caused the behavior: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D205358 Prior, I was using the broken functionality as a feature: tar -cf - file file file-may-be-here file file, and it was fine up till 10.= 3. Now in 11.0-RELEASE, it breaks. But it's ugly. # ls foo that this # tar cvf - 404 > /dev/null tar: 404: Cannot stat: No such file or directory tar: Error exit delayed from previous errors. # echo $? 1 That's all fine and dandy. I think it could be reasonable behavior. What I don't like is this. # tar cvf - foo that this 404 that this 404 that this > /dev/null a foo a foo/bar a that a this tar: 404: Cannot stat: No such file or directory tar: INTERNAL ERROR: Function 'archive_read_disk_open' invoked with archive structure in state 'header', should be in state 'new/closed': Unknown error= : -1 tar: INTERNAL ERROR: Function 'archive_read_disk_open' invoked with archive structure in state 'header', should be in state 'new/closed': Unknown error= : -1 tar: INTERNAL ERROR: Function 'archive_read_disk_open' invoked with archive structure in state 'header', should be in state 'new/closed': Unknown error= : -1 tar: INTERNAL ERROR: Function 'archive_read_disk_open' invoked with archive structure in state 'header', should be in state 'new/closed': Unknown error= : -1 tar: INTERNAL ERROR: Function 'archive_read_disk_open' invoked with archive structure in state 'header', should be in state 'new/closed': Unknown error= : -1 tar: Error exit delayed from previous errors. # echo $? 1 It at least returns 1, but it doesn't stop execution. It seems to get into a pretty yucky state. I think maybe tar isn't handling the return from libarc= hive properly? I think tar should quit immediately on a failure like this, rather than spinning its wheels in a weird state. In order to see the libarchive error, you have to give tar at least one more file argument after a file that doesn't exist. Thank you! --=20 You are receiving this mail because: You are the assignee for the bug.=