Date: Mon, 2 Nov 2015 12:47:18 +0100 From: Michal Meloun <mmel@freebsd.org> To: Gleb Smirnoff <glebius@FreeBSD.org>, Alexey Dokuchaev <danfe@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r290234 - head/share/misc Message-ID: <56374D46.9040506@freebsd.org> In-Reply-To: <20151102103757.GE78469@FreeBSD.org> References: <201511011654.tA1GstJP054578@repo.freebsd.org> <20151102071346.GA12970@FreeBSD.org> <20151102103757.GE78469@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Dne 02.11.2015 v 11:37 Gleb Smirnoff napsal(a): > On Mon, Nov 02, 2015 at 07:13:46AM +0000, Alexey Dokuchaev wrote: > A> On Sun, Nov 01, 2015 at 04:54:55PM +0000, Michal Meloun wrote: > A> > New Revision: 290234 A> > URL: > https://svnweb.freebsd.org/changeset/base/290234 A> > A> > Log: A> > > Install myself as src committer. A> > A> > Approved by: kib > (mentor) A> > > Description of fields to fill in above: > 76 columns --| A> > [ garbage omitteed ] A> A> Here is a small > advice: do not rely on "svn ci" calling your $EDITOR for A> you, > compose the message yourself first and then do "svn ci -F > $logfile". A> For one-liners, "svn ci -m message" works even > better. > > Alternatively: rely on $EDITOR, but don't trust the line: > > --This line, and those below, will be ignored-- > > Finalize your message manually. > > P.S. Not that there is bugs in the svn, but you can have touched > the line. > I'm sorry to all, it’s my bug. Commit using editor (but using git) is standard practice here @work. So I automatically select same workflow for FreeBSD. Anyway, I already got hit from kib@, so I'll use a file for commit log next time. But i'm pretty sure that i have not touched template. I only deleted all prepared unfilled lines (for PR:, MFC: ...) and then i paste commit message. And, ironically, only - --This line, and those below, will be ignored-- line has been omitted from real commit log. Michal -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWN01GAAoJEGkesmtexaqqGvEIAICYBFTeblZZ+C3Y82JqN97h fnFHNG0wyJEhj9a4jDBWyAJldU4kesa2XHw2I8dGIUB9Iz+Vp0nnib5WIvhWPL7S t1NdQDyy9MELAXx0v4wNnyDexl+YYM9nEGvQokesFV/V0vI+6WctjMM8S8tnRs1e hVu80ZgbvJOTTV6OuNl9/Cjo4oPeh3IWZMlLuYP95pV4vzlgoF6CPimrdki8gVMX dW/9DUIJd1bX73LYoCtwfM0WZEFFbbgrpBO8DJbSWEmx1hJUQmk5mYE8jUYDk9Ot 8wxE+3n1g5ovZUQGREiR5s+3xu7MJ8PSroLIM69kJUvER0pAedXkDphYm/l8v8g= =s8VI -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?56374D46.9040506>