From owner-freebsd-current@FreeBSD.ORG Sun Mar 25 20:39:42 2007 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 8F8BA16A401; Sun, 25 Mar 2007 20:39:42 +0000 (UTC) (envelope-from keramida@freebsd.org) Received: from igloo.linux.gr (igloo.linux.gr [62.1.205.36]) by mx1.freebsd.org (Postfix) with ESMTP id 0A6AD13C48C; Sun, 25 Mar 2007 20:39:41 +0000 (UTC) (envelope-from keramida@freebsd.org) Received: from kobe.laptop (dialup96.ach.sch.gr [81.186.70.96]) (authenticated bits=128) by igloo.linux.gr (8.13.8/8.13.8/Debian-3) with ESMTP id l2PKRtQW021775 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sun, 25 Mar 2007 23:28:04 +0300 Received: from kobe.laptop (kobe.laptop [127.0.0.1]) by kobe.laptop (8.13.8/8.13.8) with ESMTP id l2PKRnMI001596; Sun, 25 Mar 2007 23:27:50 +0300 (EEST) (envelope-from keramida@freebsd.org) Received: (from keramida@localhost) by kobe.laptop (8.13.8/8.13.8/Submit) id l2PKRntH001595; Sun, 25 Mar 2007 23:27:49 +0300 (EEST) (envelope-from keramida@freebsd.org) Date: Sun, 25 Mar 2007 23:27:49 +0300 From: Giorgos Keramidas To: andre@freebsd.org Message-ID: <20070325202749.GA1503@kobe.laptop> References: <20070324124732.GA767@nagual.pp.ru> <200703251348.58972.nb_root@videotron.ca> <20070325194946.GC79938@kobe.laptop> <200703251620.20879.nb_root@videotron.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200703251620.20879.nb_root@videotron.ca> X-Hellug-MailScanner: Found to be clean X-Hellug-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-4.088, required 5, autolearn=not spam, ALL_TRUSTED -1.80, AWL 0.31, BAYES_00 -2.60) X-Hellug-MailScanner-From: keramida@freebsd.org X-Spam-Status: No Cc: freebsd-current@freebsd.org, Nicolas Blais Subject: Re: Latest -current complete lockup (tcp changes?) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Mar 2007 20:39:42 -0000 Hi Andre, The attached thread below is a reply from Nicolas Blais which shows some problems with the recent SACK changes. Any idea how we can proceed from this point? - Giorgos On 2007-03-25 16:20, Nicolas Blais wrote: > On March 25, 2007 03:49:46 pm Giorgos Keramidas wrote: > > On 2007-03-25 13:48, Nicolas Blais wrote: > > > > The panic happens after a small amount of network activity, inside > > > > the TCP SACK code: > > > > > > > > ----------------------------------------------------------------------- > > > >---- Disabling SACK lets me use my laptop again: > > > > > > > > net.inet.tcp.sack.enable=0 > > > > > > > > without any panics. > > > > > > Same here. If you want to quickly crash your system, > > > net.inet.tcp.sack.enable=1 and start a torrent :) > > > > > > I couldn't find what was causing my desktop to crash until I STOPPED > > > trying to restart my torrent after boot :) . Though > > > net.inet.tcp.sack.enable=0 fixed it. > > > > Rebuilding a kernel will take a while here. If you can try reverting > > the following commit before I do, let me know if it fixes the panic. > > > > % andre 2007-03-23 18:33:21 UTC > > % > > % FreeBSD src repository > > % > > % Modified files: > > % sys/netinet tcp_input.c tcp_sack.c > > % Log: > > % Bring SACK option handling in tcp_dooptions() in line with all other > > % options and ajust users accordingly. > > % > > % Revision Changes Path > > % 1.326 +7 -4 src/sys/netinet/tcp_input.c > > % 1.35 +1 -0 src/sys/netinet/tcp_sack.c > > Done. > > I reverted tcp_input.c to 1.325 and tcp_sack.c to 1.34. I was able to start > many torrents without a panic. I believe the revert fixed the problem, as > previously, just starting 1 torrent would panic (unless > net.inet.tcp.sack.enable=0) , now I have 5 running fine. > > Nicolas.