Date: Wed, 7 Nov 2018 10:15:13 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Koichiro Iwao <meta@freebsd.org> Cc: Niclas Zeising <zeising@freebsd.org>, Baptiste Daroussin <bapt@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r484357 - head/mail/spamassassin Message-ID: <20181107101513.GA81078@FreeBSD.org> In-Reply-To: <20181107095528.szgl6dytu7zuos5r@icepick.vmeta.jp> References: <201811062146.wA6LknN3005274@repo.freebsd.org> <20181107083105.55o52urafcgdthec@ivaldir.net> <20181107091004.xbvzfyviyrkcbi2m@icepick.vmeta.jp> <ca100d9e-c455-27c3-5605-2ecbb3c5a4bb@freebsd.org> <20181107092211.dgcvichyunbss35x@ivaldir.net> <2b3670de-7625-d458-7c93-5ea0a7ae2af1@freebsd.org> <20181107095528.szgl6dytu7zuos5r@icepick.vmeta.jp>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Nov 07, 2018 at 06:55:28PM +0900, Koichiro Iwao wrote: > ... > +1 to single port. I concern about not all people need that patch. Can > FLAVORS be used to create packages with/without Japanese patches? > I know it can be used to handle multiple versions of PHP, Python, etc. There's nothing wrong with a patch not being *useful* to all people, the question is would it break anything for anyone. If there are no undesired side effects just commit it without hiding it behind options or flavors. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20181107101513.GA81078>