From owner-svn-ports-all@freebsd.org  Wed Oct  2 12:00:23 2019
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 59A7C12CC85;
 Wed,  2 Oct 2019 12:00:23 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 server-signature RSA-PSS (4096 bits)
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 46jvpb1jvyz4K2V;
 Wed,  2 Oct 2019 12:00:23 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1354)
 id E78661B4DF; Wed,  2 Oct 2019 12:00:22 +0000 (UTC)
From: Jan Beich <jbeich@FreeBSD.org>
To: Adriaan de Groot <adridg@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r513568 - head/x11-toolkits/qt5-gui
References: <201910021047.x92AlBmm053221@repo.freebsd.org>
Date: Wed, 02 Oct 2019 14:00:19 +0200
In-Reply-To: <201910021047.x92AlBmm053221@repo.freebsd.org> (Adriaan de
 Groot's message of "Wed, 2 Oct 2019 10:47:11 +0000 (UTC)")
Message-ID: <wodn-l5m4-wny@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Oct 2019 12:00:23 -0000

Adriaan de Groot <adridg@FreeBSD.org> writes:

> Author: adridg
> Date: Wed Oct  2 10:47:10 2019
> New Revision: 513568
> URL: https://svnweb.freebsd.org/changeset/ports/513568
>
> Log:
>   Fix more trivial typo's / wording
>
> Modified:
>   head/x11-toolkits/qt5-gui/Makefile
>
> Modified: head/x11-toolkits/qt5-gui/Makefile
> ==============================================================================
> --- head/x11-toolkits/qt5-gui/Makefile	Wed Oct  2 10:37:13 2019	(r513567)
> +++ head/x11-toolkits/qt5-gui/Makefile	Wed Oct  2 10:47:10 2019	(r513568)
> @@ -35,8 +35,8 @@ HAS_CONFIGURE=	yes
>  CONFIGURE_ARGS=	-no-eglfs \
>  		-no-libudev \
>  		-system-harfbuzz
> -# Explicitly set to c++14 as to net get c++17/c++1z, as libX11's headers
> -# are using the obsolete 'register' key word.
> +# Explicitly set to c++14 to avoid c++17/c++1z, since libX11's headers
> +# are using the obsolete 'register' keyword.
>  CONFIGURE_ARGS+=	-c++std c++14

Why not drop entirely? -isystem passed via USES=localbase hides warnings
in system headers.

https://gcc.gnu.org/onlinedocs/cpp/System-Headers.html