From owner-freebsd-stable@FreeBSD.ORG Fri Jul 13 19:03:40 2007 Return-Path: X-Original-To: stable@freebsd.org Delivered-To: freebsd-stable@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 659C416A401 for ; Fri, 13 Jul 2007 19:03:40 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.freebsd.org (Postfix) with ESMTP id 094C713C474 for ; Fri, 13 Jul 2007 19:03:39 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l6DJ3cFP005915; Fri, 13 Jul 2007 15:03:38 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Volker Date: Fri, 13 Jul 2007 14:47:23 -0400 User-Agent: KMail/1.9.6 References: <200707111442.33336.jhb@freebsd.org> <4697BFBB.1050009@vwsoft.com> In-Reply-To: <4697BFBB.1050009@vwsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200707131447.23846.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Fri, 13 Jul 2007 15:03:38 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/3661/Fri Jul 13 13:18:05 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: stable@freebsd.org Subject: Re: Call for testing: patch that helps Wine on 6.x X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jul 2007 19:03:40 -0000 On Friday 13 July 2007 02:08:59 pm Volker wrote: > On 07/11/07 20:42, John Baldwin wrote: > > This patch attempts to remove a gross hack with a slightly less gross hack in > > order to avoid clobbering data in signal info that Wine needs. In 7 this was > > fixed by a major change to how the kernel manages signals internally, and > > that change is too large to be MFC'd, hence this lighter weight patch. It > > has already been tested by the folks working on Wine, but I would like a bit > > more widespread testing before I commit it. Please test this patch and let > > me know if anything breaks. Note that this patch is only for i386. > > > > http://www.FreeBSD.org/~jhb/patches/sig_eva.patch > > > > John, > > I've patched and recompiled world + kernel using your patch. I can > confirm it does not hurt but what does it good (my wine already ran > fine despite some DDE and performance issues)? What to look for > especially - any specific test procedures? I'm not as familiar with what it fixes for wine, but it fixes one part of the siginfo for signals to not contain garbage. -- John Baldwin