Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 16 Feb 2003 02:51:42 +0300
From:      "Andrey A. Chernov" <ache@nagual.pp.ru>
To:        Dag-Erling Smorgrav <des@ofug.org>
Cc:        src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/lib/libpam/modules/pam_opieaccess pam_opieaccess.c
Message-ID:  <20030215235142.GH72156@nagual.pp.ru>
In-Reply-To: <xzplm0hm7h9.fsf@flood.ping.uio.no>
References:  <200302152326.h1FNQnAr027546@repoman.freebsd.org> <20030215233943.GC72156@nagual.pp.ru> <20030215234406.GD72156@nagual.pp.ru> <xzplm0hm7h9.fsf@flood.ping.uio.no>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Feb 16, 2003 at 00:47:46 +0100, Dag-Erling Smorgrav wrote:
> "Andrey A. Chernov" <ache@nagual.pp.ru> writes:
> > Look at this code from accessfile.c:
> >  if (!host[0])
> >     /* Local login, okay */
> >     return (1);
> 
> That is an *empty* host name, not a NULL one.  Go bother someone else.

Empty host name means localhost, i.e. occurse for localhost case. Your 
explicit addition of "localhost" string break this code, since "" != 
"localhost". After adding "localhost" breakage you forced to change 
/etc/opieaccess because default "" case for localhost not works anymore.

Correct solution will be:
if (host == NULL)
	host = "";

-- 
Andrey A. Chernov
http://ache.pp.ru/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030215235142.GH72156>