Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 8 Sep 2014 04:49:20 GMT
From:      John-Mark Gurney <jmg@FreeBSD.org>
To:        Perforce Change Reviews <perforce@FreeBSD.org>
Subject:   PERFORCE change 1198728 for review
Message-ID:  <201409080449.s884nKkI020744@skunkworks.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://p4web.freebsd.org/@@1198728?ac=10

Change 1198728 by jmg@jmg_carbon2 on 2014/08/14 18:57:09

	make _mulalpha an inline as it's only used once...
	
	update comment on what platform I tested it on that it was
	faster...

Affected files ...

.. //depot/projects/opencrypto/sys/opencrypto/gfmult.c#3 edit

Differences ...

==== //depot/projects/opencrypto/sys/opencrypto/gfmult.c#3 (text+ko) ====

@@ -40,7 +40,7 @@
 };
 
 /* calulate v * 2 */
-static struct gf128
+static inline struct gf128
 gf128_mulalpha(struct gf128 v)
 {
 	uint64_t mask;
@@ -167,7 +167,8 @@
  * ...
  * 2^4 + worda[63,60]*h^4+ ... + wordd[63,60]*h
  *
- * Passing/returning struct is .5% faster than passing in via pointer.
+ * Passing/returning struct is .5% faster than passing in via pointer on
+ * amd64.
  */
 static struct gf128
 gfmultword4(uint64_t worda, uint64_t wordb, uint64_t wordc, uint64_t wordd,



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201409080449.s884nKkI020744>