From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Dec 26 08:00:25 2005 Return-Path: X-Original-To: freebsd-ports-bugs@hub.freebsd.org Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3028F16A41F for ; Mon, 26 Dec 2005 08:00:25 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id E4F4A43D45 for ; Mon, 26 Dec 2005 08:00:24 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id jBQ80OBl004679 for ; Mon, 26 Dec 2005 08:00:24 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id jBQ80O8N004678; Mon, 26 Dec 2005 08:00:24 GMT (envelope-from gnats) Date: Mon, 26 Dec 2005 08:00:24 GMT Message-Id: <200512260800.jBQ80O8N004678@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org From: Sergey Matveychuk Cc: Subject: Re: ports/90729: databases/db[0-9]*: check USE_BDB knob X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Sergey Matveychuk List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Dec 2005 08:00:25 -0000 The following reply was made to PR ports/90729; it has been noted by GNATS. From: Sergey Matveychuk To: bug-followup@FreeBSD.org, leeym@utopia.leeym.com Cc: matthias.andree@gmx.de Subject: Re: ports/90729: databases/db[0-9]*: check USE_BDB knob Date: Mon, 26 Dec 2005 10:49:51 +0300 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 > What problem is the patch trying to fix? I see none until here. Using > other targets, we get: Some users like set USE_smth=foo in their /etc/make.conf. It makes an infinite loop when db* ports build. > And why would the port need to be fixed rather than bsd.database.mk? 1) I think to fix ports is easier. You just should check USE_BDB macro is set. In bsd.database.mk you should do some magic with PORTNAME. 2) It's a common practice. See archivers/bzip2, devel/bison, devel/gmake etc. - -- Sem. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (MingW32) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFDr6CfTclL2LcfYF0RAvwkAJ9D2LZcA2tgIt1yP9l6KjjHTzXwVwCfWFXy laTEUhkF1ELg0AoIgy163z4= =coUa -----END PGP SIGNATURE-----