Date: Wed, 22 Jan 2014 10:16:11 +0100 From: Mathieu Arnold <mat@FreeBSD.org> To: Alex Dupre <ale@FreeBSD.org>, Alexey Dokuchaev <danfe@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r340618 - head/security/cryptlib Message-ID: <1EEC25E6DEEADBD0368A62DD@ogg.in.absolight.net> In-Reply-To: <5CC219416A3809A85702532B@ogg.in.absolight.net> References: <201401211633.s0LGXRLP049969@svn.freebsd.org> <20140122013352.GA12715@FreeBSD.org> <52DF7EBE.3080103@FreeBSD.org> <5CC219416A3809A85702532B@ogg.in.absolight.net>
next in thread | previous in thread | raw e-mail | index | archive | help
+--On 22 janvier 2014 10:01:43 +0100 Mathieu Arnold <mat@FreeBSD.org> wrote:
| +--On 22 janvier 2014 09:18:06 +0100 Alex Dupre <ale@FreeBSD.org> wrote:
|| Alexey Dokuchaev ha scritto:
||>> +OPTIONS_DEFINE= DOCS
||>
||> Couple of observations. :)
||>
||> OPTIONS are normally placed below all other knobs (traditionally).
||
|| Hmm, no :-)
||
||>> + ${LN} -sf ${PREFIX}/lib/libcl.so.${PORTVERSION}
||>> ${STAGEDIR}${PREFIX}/lib/libcl.so.3 + ${LN} -sf
||>> ${PREFIX}/lib/libcl.so.3 ${STAGEDIR}${PREFIX}/lib/libcl.so
||>
||> Per our own wiki.freebsd.org/ports/StageDir:
||>
||> "When creating a symlink, prepend ${STAGEDIR} to the target path only
||> (and generally try to avoid using absolute paths in source). [...]
||
|| You are right here, but I didn't change the source. Improved.
|
| Actually, it could have been only
|
| ${LN} -sf libcl.so.${PORTVERSION} ${STAGEDIR}${PREFIX}/lib/libcl.so.3
| ${LN} -sf libcl.so.3 ${STAGEDIR}${PREFIX}/lib/libcl.so
|
| They're in the same directory, the symlinks would resolve just fine.
Which is what Alexey said, yes.
--
Mathieu Arnold
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1EEC25E6DEEADBD0368A62DD>