From owner-freebsd-scsi@FreeBSD.ORG Fri Jul 19 16:35:43 2013 Return-Path: Delivered-To: freebsd-scsi@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id E308C674 for ; Fri, 19 Jul 2013 16:35:43 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 2169C36A for ; Fri, 19 Jul 2013 16:35:42 +0000 (UTC) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id TAA11614 for ; Fri, 19 Jul 2013 19:35:41 +0300 (EEST) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1V0Def-000A6O-6b for freebsd-scsi@freebsd.org; Fri, 19 Jul 2013 19:35:41 +0300 Message-ID: <51E96A8C.7050301@FreeBSD.org> Date: Fri, 19 Jul 2013 19:34:20 +0300 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130708 Thunderbird/17.0.7 MIME-Version: 1.0 To: freebsd-scsi@FreeBSD.org Subject: Re: xpt_schedule_dev: priority of new entry References: <516EC5F7.5030908@FreeBSD.org> In-Reply-To: <516EC5F7.5030908@FreeBSD.org> X-Enigmail-Version: 1.5.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jul 2013 16:35:44 -0000 [ping] on 17/04/2013 18:55 Andriy Gapon said the following: > > I wonder what is the reason for the following code: > /* New entry on the queue */ > if (new_priority < old_priority) > pinfo->priority = new_priority; > > Shouldn't we unconditionally honor new_priority given that this is the new entry case? > -- Andriy Gapon