Date: Tue, 03 Mar 2009 08:48:32 -0800 From: Doug Barton <dougb@FreeBSD.org> To: Oliver Lehmann <lehmann@ans-netz.de> Cc: ports@freebsd.org, stable@freebsd.org, Artis Caune <artis.caune@gmail.com> Subject: Re: restart a script in etc/rc.d Message-ID: <49AD5F60.7040208@FreeBSD.org> In-Reply-To: <20090303065208.87200365.lehmann@ans-netz.de> References: <20090302163843.cc66c55e.lehmann@ans-netz.de> <alpine.BSF.2.00.0903021100190.59723@qbhto.arg> <20090302202520.eaf09b15.lehmann@ans-netz.de> <9e20d71e0903021355i3ad66b8fx14bdc3b395e311a5@mail.gmail.com> <9e20d71e0903021410i26ca8088oc2de76009b2773d2@mail.gmail.com> <49AC5C66.70301@FreeBSD.org> <20090303065208.87200365.lehmann@ans-netz.de>
next in thread | previous in thread | raw e-mail | index | archive | help
Oliver Lehmann wrote:
> Doug Barton wrote:
>
>> Artis Caune wrote:
>>> There is logic error in bacula rc.d script. It should first set
>>> default variables and only then use them.
>>> pidfile="${bacula_fd_pidfile}"
>>> : ${bacula_fd_pidfile="/var/run/bacula-fd.9102.pid"}
>>>
>>> If you don't set pidfile in rc.conf, pidfile is "" so it kills all bacula-fd's
>> Yes, I tried to convince the OP to fix this, but he thought he had it
>> covered, so I'm giving him the opportunity to prove me wrong. :)
>
> Yeah this did it - Its working now.
> I thought you where just telling me that to have another pidfile for the
> 2nd start script - I missed the point that it was empty for the first one
> and because of that it is falling back to ps...
>
> I'll probably write a PR and commit it after aproval for PROVIDE and the
> pidfile setting...
Excellent. :)
Doug
--
This .signature sanitized for your protection
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?49AD5F60.7040208>