Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 15 Oct 2021 08:24:20 +0000
From:      bugzilla-noreply@freebsd.org
To:        gecko@FreeBSD.org
Subject:   [Bug 239873] www/firefox and mail/thunderbird don't like the new ASLR "stackgap" feature
Message-ID:  <bug-239873-21738-WY9gxkncKP@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-239873-21738@https.bugs.freebsd.org/bugzilla/>
References:  <bug-239873-21738@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D239873

--- Comment #17 from commit-hook@FreeBSD.org ---
A commit in branch main references this bug:

URL:
https://cgit.FreeBSD.org/src/commit/?id=3D78df56ccfcb40013a3e6904bd6d398362=
20c3550

commit 78df56ccfcb40013a3e6904bd6d39836220c3550
Author:     Dawid Gorecki <dgr@semihalf.com>
AuthorDate: 2021-10-13 19:06:05 +0000
Commit:     Marcin Wojtas <mw@FreeBSD.org>
CommitDate: 2021-10-15 08:21:56 +0000

    libthr: Use kern.stacktop for thread stack calculation.

    Use the new kern.stacktop sysctl to retrieve the address of stack top
    instead of kern.usrstack. kern.usrstack does not have any knowledge
    of the stack gap, so this can cause problems with thread stacks.
    Using kern.stacktop sysctl should fix most of those problems.
    kern.usrstack is used as a fallback when kern.stacktop cannot be read.

    Rename usrstack variables to stacktop to reflect this change.

    Fixes problems with firefox and thunderbird not starting with
    stack gap enabled.

    PR: 239873
    Reviewed by: kib
    Obtained from: Semihalf
    Sponsored by: Stormshield
    MFC after: 1 month
    Differential Revision: https://reviews.freebsd.org/D31898

 lib/libthr/thread/thr_init.c    | 19 +++++++++++--------
 lib/libthr/thread/thr_private.h |  2 +-
 lib/libthr/thread/thr_stack.c   | 22 ++++++++++++----------
 3 files changed, 24 insertions(+), 19 deletions(-)

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-239873-21738-WY9gxkncKP>