Date: Sat, 23 Jun 2018 16:16:56 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Eitan Adler <eadler@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r335547 - head/usr.bin/top Message-ID: <20180623161656.GB91517@FreeBSD.org> In-Reply-To: <201806220945.w5M9jI5H044405@repo.freebsd.org> References: <201806220945.w5M9jI5H044405@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jun 22, 2018 at 09:45:18AM +0000, Eitan Adler wrote: > New Revision: 335547 > URL: https://svnweb.freebsd.org/changeset/base/335547 > > Log: > top(1): remove special handling of load > 5 > > ... > Modified: head/usr.bin/top/screen.c > ============================================================================== > --- head/usr.bin/top/screen.c Fri Jun 22 09:41:13 2018 (r335546) > +++ head/usr.bin/top/screen.c Fri Jun 22 09:45:18 2018 (r335547) > @@ -55,7 +55,7 @@ static struct termios new_settings; > static char is_a_terminal = false; > > void > -init_termcap(int interactive) > +init_termcap(bool interactive) > { > char *bufptr; > char *PCptr; > @@ -138,7 +138,7 @@ init_termcap(int interactive) > /* get "ce", clear to end */ > if (!overstrike) > { > - clear_line = tgetstr("ce", &bufptr); > + clear_line = tgetstr("ce", &bufptr); > } (I've seen it before, and replying to this commit as an example): would you mind separating style and functional changes into different commits? I know that top(1) is full of style bugs and it's very tempting to fix them when you see them, but that's not really the best way to go. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180623161656.GB91517>