From owner-svn-src-all@FreeBSD.ORG Mon Jan 19 09:11:01 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 73AAE106564A for ; Mon, 19 Jan 2009 09:11:01 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: from rv-out-0506.google.com (rv-out-0506.google.com [209.85.198.236]) by mx1.freebsd.org (Postfix) with ESMTP id 3A7308FC0C for ; Mon, 19 Jan 2009 09:11:00 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: by rv-out-0506.google.com with SMTP id b25so2648249rvf.43 for ; Mon, 19 Jan 2009 01:11:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:received:received:date:from :to:cc:subject:message-id:reply-to:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=uPUdKPvfhmJhjHfZXWcnyZq2ZRRIndRO4hSy99M3HRE=; b=kPDkqyuG75SicFRmidDv6nTCd/I/XNLQzf04auoV/QxnUu0lWVra4lBRkBO/LhwjGU FTBM49f+mc9tZ2Py/NvH0CGMsnNQk2xyiNViSJLfhWVvO7K0v76eF4sYum+wGc4K4U7r HRS9nwM6QVIbDwHze85nxCSHPygPBaMe/AaEU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=AIJmW2Mcqb8Yh7hrtL0nYoBopmO7oEK5S3SWzYAVtZ07HHrcEWGSfn30rXHTYzNcYG k9HZQVd+wMJxcMKFcZsIVBCiOTHaK1Q8H4BDBgUHSBdyumy6mq3psMDyslWRKNpyJmOM su9tV24uvzpg11Ps8j10mNY5PMnnm/rUKzpOc= Received: by 10.140.207.2 with SMTP id e2mr981877rvg.251.1232354620777; Mon, 19 Jan 2009 00:43:40 -0800 (PST) Received: from michelle.cdnetworks.co.kr ([211.53.35.84]) by mx.google.com with ESMTPS id f42sm4221490rvb.5.2009.01.19.00.43.36 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 19 Jan 2009 00:43:39 -0800 (PST) Received: from michelle.cdnetworks.co.kr (localhost.cdnetworks.co.kr [127.0.0.1]) by michelle.cdnetworks.co.kr (8.14.3/8.14.3) with ESMTP id n0J8hUqb077134 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 19 Jan 2009 17:43:30 +0900 (KST) (envelope-from pyunyh@gmail.com) Received: (from yongari@localhost) by michelle.cdnetworks.co.kr (8.14.3/8.14.3/Submit) id n0J8hTwl077133; Mon, 19 Jan 2009 17:43:29 +0900 (KST) (envelope-from pyunyh@gmail.com) Date: Mon, 19 Jan 2009 17:43:29 +0900 From: Pyun YongHyeon To: Maxim Sobolev Message-ID: <20090119084329.GF75541@cdnetworks.co.kr> References: <200901190710.n0J7ACSg001385@svn.freebsd.org> <497432A1.9060805@samsco.org> <49743712.7030103@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <49743712.7030103@FreeBSD.org> User-Agent: Mutt/1.4.2.3i Cc: svn-src-head@freebsd.org, Scott Long , src-committers@freebsd.org, svn-src-all@freebsd.org Subject: Re: svn commit: r187426 - head/sys/amd64/conf X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pyunyh@gmail.com List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Jan 2009 09:11:01 -0000 On Mon, Jan 19, 2009 at 12:17:22AM -0800, Maxim Sobolev wrote: > Scott Long wrote: > >Maxim Sobolev wrote: > >>Author: sobomax > >>Date: Mon Jan 19 07:10:11 2009 > >>New Revision: 187426 > >>URL: http://svn.freebsd.org/changeset/base/187426 > >> > >>Log: > >> Add asr(4) and stge(4) from i386 GENERIC. Both drivers compile on > >>amd64 and > >> there is no particular reason for them to be i386-only. > > > >Yes, there is a particular reason why asr is i386 only. This has been > >discussed extensively over the years, but to sum it up, no it is not > >64-bit clean. Please remove. > > > >At this point in the lifecycle of amd64, you can be 100% assured that > >the list of compatible devices has been checked and rechecked a few > >dozen times. You are not going to find hidden gems that people have > >forgotten about. If you think you've found something, ask first, and > >prepare to be wrong. And above all else, don't put drivers into here > >that you haven't tested. It's pretty silly to admit in your commit > >message, for all to see, that you are blatantly committing without > >testing. > > Point taken, thanks. Is there any technical reason why stge(4) not in there? > The only reason I didn't enable it at that time was lack of testing. I think it should work without problems as I had also tested it on sparc64. -- Regards, Pyun YongHyeon