From owner-freebsd-ports@FreeBSD.ORG Mon Jul 26 21:02:55 2004 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D8EF216A4CE; Mon, 26 Jul 2004 21:02:55 +0000 (GMT) Received: from ulysses.noc.ntua.gr (ulysses.noc.ntua.gr [147.102.222.230]) by mx1.FreeBSD.org (Postfix) with ESMTP id 19CCA43D31; Mon, 26 Jul 2004 21:02:55 +0000 (GMT) (envelope-from past@netmode.ntua.gr) Received: from netmode.ece.ntua.gr (dolly.netmode.ece.ntua.gr [147.102.13.10]) by ulysses.noc.ntua.gr (8.12.9p1/8.12.9) with ESMTP id i6QJtjIs091232; Mon, 26 Jul 2004 22:55:45 +0300 (EEST) (envelope-from past@netmode.ntua.gr) Received: from [147.102.229.10] (ppp-229-010.dialup.ntua.gr [147.102.229.10]) by netmode.ece.ntua.gr (8.12.10/8.12.8) with ESMTP id i6QJtiNC096519; Mon, 26 Jul 2004 22:55:45 +0300 (EEST) (envelope-from past@netmode.ntua.gr) Message-ID: <410561BB.8080603@netmode.ntua.gr> Date: Mon, 26 Jul 2004 22:55:39 +0300 From: Panagiotis Astithas User-Agent: Mozilla Thunderbird 0.7 (X11/20040702) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Jeremy Faulkner References: <20040725171544.71dc613e.nork@FreeBSD.org> <41042F42.80604@gldis.ca> <4104BD5F.70608@ebs.gr> <41053064.1020208@gldis.ca> In-Reply-To: <41053064.1020208@gldis.ca> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: ports@freebsd.org cc: Norikatsu Shigemura cc: freebsd-java@freebsd.org Subject: Re: HEADS UP: Eclipse 3.0 updated X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Jul 2004 21:02:56 -0000 Jeremy Faulkner wrote: > I did not describe my fix, I described the problem. Here is another > patch that removes the unnecessary greps. The redirection of stderr in > this patch to /dev/null is only to avoid having it go to console during > the compile. > > It doesn't really matter if you have KDE installed or not, you can test > the fix by making it search for a pkg that you don't have installed. > > pkg_info -xc 'SomePkgThatIsNotInstalled' > test.txt > > cat test.txt > > > pkg_info -xc 'SomePkgThatIsInstalled' > test.txt > > cat test.txt > > > So, pkg_info returns nothing to stderr if the pkg is not installed, and > returns the pkg information if the pkg is installed, thus the logic > reversal in the if statement. (I suppose you meant s/stderr/stdout/) Thanks, I can see what you meant now. I'm OK with this, if you have verified that the patch works (I can't test it unfortunately). Cheers, Panagiotis