Date: Thu, 25 Mar 1999 11:15:40 +0100 From: Eivind Eklund <eivind@FreeBSD.org> To: Luigi Rizzo <luigi@labinfo.iet.unipi.it> Cc: Bruce Evans <bde@zeta.org.au>, mike@smith.net.au, cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, luigi@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet ip_dummynet.c Message-ID: <19990325111540.B57330@bitbox.follo.net> In-Reply-To: <199903250723.IAA12325@labinfo.iet.unipi.it>; from Luigi Rizzo on Thu, Mar 25, 1999 at 08:23:27AM %2B0100 References: <199903250917.UAA16527@godzilla.zeta.org.au> <199903250723.IAA12325@labinfo.iet.unipi.it>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Mar 25, 1999 at 08:23:27AM +0100, Luigi Rizzo wrote: > There is another thing: having to explicitly include "opt_foo.h" in all > files related to "foo" opens the door to subtle bugs that might not be > detected at compile time or might even cause inconsistent behaviour at > run time. ... just like having the keys '1' and '2' next to each other on the keyboard opens for typing a number incorrectly, which can lead to subtle bugs and inconsistent behaviour at run time ;-) WRT options: You are either going to be doing large-scale mods to lots of stuff you can't test (e.g, device driver mods for bridge), in which case correct inclusion of opt_xxx.h should be on your checklist before committing the changes, or you are writing new code which needs the option (in which case you should test the code, so this shouldn't be a problem). > I understand that name space pollution issues do not leave the option > of having all "opt_*" included in "opt_global.h" unless we standardize names > in a way that reduces conflicts... So should we go for that, e.g. having > > OPT_* for generic options > DEV_* for devices > > and so on ? I'll oppose any change that removes individual dependency tracking for options. Cleaning up to option names would be nice, of course, but it seems unlikely. Besides, it is better to eliminate an option than to rename it :-) Eivind. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19990325111540.B57330>