Date: Wed, 7 Nov 2018 13:30:43 +0100 From: Niclas Zeising <zeising@freebsd.org> To: Baptiste Daroussin <bapt@freebsd.org>, Alexey Dokuchaev <danfe@freebsd.org> Cc: Koichiro Iwao <meta@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r484357 - head/mail/spamassassin Message-ID: <d5f07507-12b2-b814-6cda-e2725bd6230f@freebsd.org> In-Reply-To: <20181107121217.p5ira4vn556t4t2z@ivaldir.net> References: <201811062146.wA6LknN3005274@repo.freebsd.org> <20181107083105.55o52urafcgdthec@ivaldir.net> <20181107091004.xbvzfyviyrkcbi2m@icepick.vmeta.jp> <ca100d9e-c455-27c3-5605-2ecbb3c5a4bb@freebsd.org> <20181107092211.dgcvichyunbss35x@ivaldir.net> <2b3670de-7625-d458-7c93-5ea0a7ae2af1@freebsd.org> <20181107095528.szgl6dytu7zuos5r@icepick.vmeta.jp> <20181107101513.GA81078@FreeBSD.org> <20181107121217.p5ira4vn556t4t2z@ivaldir.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 11/7/18 1:12 PM, Baptiste Daroussin wrote: > On Wed, Nov 07, 2018 at 10:15:13AM +0000, Alexey Dokuchaev wrote: >> On Wed, Nov 07, 2018 at 06:55:28PM +0900, Koichiro Iwao wrote: >>> ... >>> +1 to single port. I concern about not all people need that patch. Can >>> FLAVORS be used to create packages with/without Japanese patches? >>> I know it can be used to handle multiple versions of PHP, Python, etc. >> >> There's nothing wrong with a patch not being *useful* to all people, >> the question is would it break anything for anyone. If there are no >> undesired side effects just commit it without hiding it behind options >> or flavors. >> >> ./danfe > > I agree with danfe here! if needed we can in the end play with flavors yes, > but if the patch does not break things to anyone and brings good for japanese > people let's just have the patch in and no options/flavors :) > I need to check with the author of that patch set if there is a reason it's not included in mainline spamassassin. In the meantime, can someone please try to translate the installation instructions for me, as found here: https://github.com/heartbeatsjp/spamassassin_ja/blob/master/docs/installation.md Thanks -- Niclas Zeising
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?d5f07507-12b2-b814-6cda-e2725bd6230f>