Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 09 Mar 2016 19:34:00 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-bugs@FreeBSD.org
Subject:   [Bug 207856] usr/src/sys/geom/vinum/geom_vinum_raid5.c: 2 * bad test ?
Message-ID:  <bug-207856-8@https.bugs.freebsd.org/bugzilla/>

next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D207856

            Bug ID: 207856
           Summary: usr/src/sys/geom/vinum/geom_vinum_raid5.c: 2 * bad
                    test ?
           Product: Base System
           Version: 11.0-CURRENT
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: kern
          Assignee: freebsd-bugs@FreeBSD.org
          Reporter: dcb314@hotmail.com

1.

usr/src/sys/geom/vinum/geom_vinum_raid5.c:602]: (style) A pointer can not be
negative so it is either pointless or an error to check if it is not.

source code is

    KASSERT(psdno >=3D 0, ("gv_raid5_offset: psdno < 0"));

but

gv_raid5_offset(struct gv_plex *p, off_t boff, off_t bcount, off_t *real_of=
f,
    off_t *real_len, int *sdno, int *psdno, int growing)

2.

usr/src/sys/geom/vinum/geom_vinum_raid5.c:610]: (style) A pointer can not be
negative so it is either pointless or an error to check if it is not.

Source code is

    KASSERT(sdno >=3D 0, ("gv_raid5_offset: sdno < 0"));

Duplicate.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-207856-8>