Date: Thu, 12 Dec 2002 10:39:01 -0800 (PST) From: Marcel Moolenaar <marcel@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 22212 for review Message-ID: <200212121839.gBCId1B9055840@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=22212 Change 22212 by marcel@marcel_nfs on 2002/12/12 10:38:48 Don't define baudrate as a 64-bit type. The structure is not 64-bit "clean". Using packed would only cause unaligned access faults. This was already done for the 64-bit address, but I missed baudrate. Affected files ... .. //depot/projects/ia64/sys/ia64/include/dig64.h#2 edit Differences ... ==== //depot/projects/ia64/sys/ia64/include/dig64.h#2 (text+ko) ==== @@ -36,7 +36,7 @@ uint8_t _reserved_; /* * XXX using a 64-bit type for the address would cause padding and - * using __packed will cause unaligned accesses... + * using __packed would cause unaligned accesses... */ uint32_t addr_low; uint32_t addr_high; @@ -57,7 +57,12 @@ uint8_t _reserved2_:3; uint8_t interrupt:1; uint8_t pci_flag:1; - uint64_t baudrate; + /* + * XXX using a 64-bit type for the baudrate would cause padding and + * using __packed would cause unaligned accesses... + */ + uint32_t baud_low; + uint32_t baud_high; struct dig64_gas address; uint16_t pci_devid; uint16_t pci_vendor; To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200212121839.gBCId1B9055840>