From owner-svn-src-projects@FreeBSD.ORG  Mon Feb  4 01:17:10 2013
Return-Path: <owner-svn-src-projects@FreeBSD.ORG>
Delivered-To: svn-src-projects@freebsd.org
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id 9ABF255F;
 Mon,  4 Feb 2013 01:17:10 +0000 (UTC)
 (envelope-from mr.kodiak@gmail.com)
Received: from mail-ia0-x22e.google.com (mail-ia0-x22e.google.com
 [IPv6:2607:f8b0:4001:c02::22e])
 by mx1.freebsd.org (Postfix) with ESMTP id 602E32FE;
 Mon,  4 Feb 2013 01:17:10 +0000 (UTC)
Received: by mail-ia0-f174.google.com with SMTP id o25so7524620iad.33
 for <multiple recipients>; Sun, 03 Feb 2013 17:17:10 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=x-received:mime-version:sender:in-reply-to:references:from:date
 :x-google-sender-auth:message-id:subject:to:cc:content-type;
 bh=/hIdaHqMGsDp08s/zdGKw8udGc68xskYEh6n183neB0=;
 b=l2RymlXD1RRHwR2RALtukNXTLakX8lgMmtWvzOsbKS1tRLOCLNngNqPDbg3nnGqFZG
 7BfLdSlamcuvZvzYC0Nfo+vX7A37PTVjiv3snru0+EVg4jh35jhe9JWheHtVjEIWJo8P
 8ygIYXkgPxuTVpYxgR5dX2W4V+GwRt4Fo6grUX10YpkbkQGuJta49XAQEe12mMA0ePZa
 /aU1IGaL67qFFIL4sTMmP5YC60euW3q90j28TVZ7FfiHoQccqX1hsCeLlrS+f+AcA72W
 kslzfWi4y4t2EW9kPowgjKqEhT3dzMqMKqAS9kX5uWRcuoHj5zHBjgjQq42Md9ddYYWv
 JCKQ==
X-Received: by 10.50.222.232 with SMTP id qp8mr3922370igc.25.1359940630140;
 Sun, 03 Feb 2013 17:17:10 -0800 (PST)
MIME-Version: 1.0
Sender: mr.kodiak@gmail.com
Received: by 10.64.142.198 with HTTP; Sun, 3 Feb 2013 17:16:40 -0800 (PST)
In-Reply-To: <201302032335.r13NZsYb088216@svn.freebsd.org>
References: <201302032335.r13NZsYb088216@svn.freebsd.org>
From: Bryan Venteicher <bryanv@freebsd.org>
Date: Sun, 3 Feb 2013 19:16:40 -0600
X-Google-Sender-Auth: JTpz1-3zygz4tEeofQnBI5cIyeU
Message-ID: <CAGaYwLdESVGOPJn6ZvhS9mtWE=xnyoSEbyLUTOhGRN4iHkJESA@mail.gmail.com>
Subject: Re: svn commit: r246307 - projects/virtio/sys/dev/virtio/block
To: Bryan Venteicher <bryanv@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Cc: svn-src-projects@freebsd.org, src-committers@freebsd.org
X-BeenThere: svn-src-projects@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the src &quot; projects&quot;
 tree" <svn-src-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-projects>, 
 <mailto:svn-src-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-projects>
List-Post: <mailto:svn-src-projects@freebsd.org>
List-Help: <mailto:svn-src-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-projects>, 
 <mailto:svn-src-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Feb 2013 01:17:10 -0000

On Sun, Feb 3, 2013 at 5:35 PM, Bryan Venteicher <bryanv@freebsd.org> wrote:
> Author: bryanv
> Date: Sun Feb  3 23:35:53 2013
> New Revision: 246307
> URL: http://svnweb.freebsd.org/changeset/base/246307
>
> Log:
>   virtio_blk: Correct stripe offset calculation
>
>   Pointed out by:       max

Oops, should be:

Pointed out by: mav

>   Approved by:  grehan (implicit)
>
> Modified:
>   projects/virtio/sys/dev/virtio/block/virtio_blk.c
>
> Modified: projects/virtio/sys/dev/virtio/block/virtio_blk.c
> ==============================================================================
> --- projects/virtio/sys/dev/virtio/block/virtio_blk.c   Sun Feb  3 23:35:05 2013        (r246306)
> +++ projects/virtio/sys/dev/virtio/block/virtio_blk.c   Sun Feb  3 23:35:53 2013        (r246307)
> @@ -725,8 +725,9 @@ vtblk_alloc_disk(struct vtblk_softc *sc,
>         if (virtio_with_feature(dev, VIRTIO_BLK_F_TOPOLOGY)) {
>                 dp->d_stripesize = dp->d_sectorsize *
>                     (1 << blkcfg->topology.physical_block_exp);
> -               dp->d_stripeoffset = dp->d_sectorsize *
> -                   blkcfg->topology.alignment_offset;
> +               dp->d_stripeoffset = (dp->d_stripesize -
> +                   blkcfg->topology.alignment_offset * dp->d_sectorsize) %
> +                   dp->d_stripesize;
>         }
>
>         if (vtblk_write_cache_enabled(sc, blkcfg) != 0)