From owner-freebsd-net@FreeBSD.ORG  Thu Mar 22 18:27:59 2012
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id EA287106564A
	for <freebsd-net@freebsd.org>; Thu, 22 Mar 2012 18:27:59 +0000 (UTC)
	(envelope-from bschmidt@techwires.net)
Received: from mail-bk0-f54.google.com (mail-bk0-f54.google.com
	[209.85.214.54])
	by mx1.freebsd.org (Postfix) with ESMTP id 5637A8FC15
	for <freebsd-net@freebsd.org>; Thu, 22 Mar 2012 18:27:59 +0000 (UTC)
Received: by bkcjc3 with SMTP id jc3so2723064bkc.13
	for <freebsd-net@freebsd.org>; Thu, 22 Mar 2012 11:27:58 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=google.com; s=20120113;
	h=sender:from:to:subject:date:user-agent:cc:references:in-reply-to
	:mime-version:content-type:content-transfer-encoding:message-id
	:x-gm-message-state;
	bh=/UEh39H1bHmy+HHNgE2BeSV2fDoORscZPtf0B5ffYfg=;
	b=B3gqUvNi6v1NA1RNnPzneH53KAqtm7d7xdTIRa4ivhuk4E595abmzM9ta3TByjofWa
	WPmd1o7tDVjpUJwcjIePb2lw0Np+5uKHwlL+UN00o6CklvT5rBRmjzjIkgaqELsKuydP
	QxJss9IGIV9WTDkWEvc80UgdC+K/PliItZcYci865yOHZySKF5wATY57fco4V+vOJ5+1
	AxnuTFxGXwoaLtZlPBtl6Q4hJ2M+TiioShzt91zSyKfBgpD6YRAMtYdGUXY8zD+8jv5Y
	CDB0ieWZndzE7K1cUIEx8m+4gHlOKKKubGwM0bnJ2EjOhQ3+5sISO0+X0zZruED/My8j
	CWGw==
Received: by 10.204.128.152 with SMTP id k24mr3313766bks.127.1332440878159;
	Thu, 22 Mar 2012 11:27:58 -0700 (PDT)
Received: from amy.lab.techwires.net (dslb-088-065-222-166.pools.arcor-ip.net.
	[88.65.222.166]) by mx.google.com with ESMTPS id
	jr13sm11470945bkb.14.2012.03.22.11.27.56
	(version=SSLv3 cipher=OTHER); Thu, 22 Mar 2012 11:27:57 -0700 (PDT)
Sender: Bernhard Schmidt <bschmidt@techwires.net>
From: Bernhard Schmidt <bschmidt@freebsd.org>
To: freebsd-net@freebsd.org
Date: Thu, 22 Mar 2012 19:28:16 +0100
User-Agent: KMail/1.13.7 (FreeBSD/9.0-STABLE; KDE/4.7.4; amd64; ; )
References: <CA+sBSoJaxxRRsUqmpN6k8q6M_SZ_605ip6auN44k5BQ7a_XOtQ@mail.gmail.com>
In-Reply-To: <CA+sBSoJaxxRRsUqmpN6k8q6M_SZ_605ip6auN44k5BQ7a_XOtQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201203221928.16271.bschmidt@freebsd.org>
X-Gm-Message-State: ALoCoQm4Ns9WemXYbI1GAFoOfB6w5Ps0bUd77zC8b0ndZ+SG9ypTyda2p0/PkJ5UWWA46PMti7T1
Cc: Monthadar Al Jaberi <monthadar@gmail.com>
Subject: Re: ifconfig meshforward command bug
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Mar 2012 18:28:00 -0000

On Thursday 22 March 2012 16:59:44 Monthadar Al Jaberi wrote:
> Hi,
> 
> I think this is a bug in ifconfig, sending val to kernel always
> results in zero.  There are a couple of these, just want to hear from
> you guys if you think this is a bug too.
> 
> --- a/sbin/ifconfig/ifieee80211.c
> +++ b/sbin/ifconfig/ifieee80211.c
> @@ -1879,13 +1879,19 @@ DECL_CMD_FUNC(set80211meshttl, val, d)
>  static
>  DECL_CMD_FUNC(set80211meshforward, val, d)
>  {
> -       set80211(s, IEEE80211_IOC_MESH_FWRD, atoi(val), 0, NULL);
> +       set80211(s, IEEE80211_IOC_MESH_FWRD, d, 0, NULL);

Seems about right, those declared with DEF_CMD() should use d.

-- 
Bernhard