From owner-freebsd-audit Mon Jul 15 4:44:51 2002 Delivered-To: freebsd-audit@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2EA1637B400 for ; Mon, 15 Jul 2002 04:44:49 -0700 (PDT) Received: from mailsrv.otenet.gr (mailsrv.otenet.gr [195.170.0.5]) by mx1.FreeBSD.org (Postfix) with ESMTP id 278FF43E31 for ; Mon, 15 Jul 2002 04:44:48 -0700 (PDT) (envelope-from keramida@FreeBSD.org) Received: from hades.hell.gr (patr530-b187.otenet.gr [212.205.244.195]) by mailsrv.otenet.gr (8.12.4/8.12.4) with ESMTP id g6FBidmc006024; Mon, 15 Jul 2002 14:44:40 +0300 (EEST) Received: from hades.hell.gr (hades [127.0.0.1]) by hades.hell.gr (8.12.5/8.12.5) with ESMTP id g6FBidft052166; Mon, 15 Jul 2002 14:44:39 +0300 (EEST) (envelope-from keramida@FreeBSD.org) Received: (from charon@localhost) by hades.hell.gr (8.12.5/8.12.5/Submit) id g6FBib4r052165; Mon, 15 Jul 2002 14:44:37 +0300 (EEST) (envelope-from keramida@FreeBSD.org) Date: Mon, 15 Jul 2002 14:44:37 +0300 From: Giorgos Keramidas To: Dag-Erling Smorgrav Cc: Bruce Evans , freebsd-audit@FreeBSD.org Subject: Re: bin/ln & WARNS=5 Message-ID: <20020715114437.GA51994@hades.hell.gr> References: <20020715202126.S40071-100000@gamplex.bde.org> <20020715111436.GD50130@hades.hell.gr> <20020715112116.GE50130@hades.hell.gr> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: FreeBSD 5.0-CURRENT i386 X-PGP-Fingerprint: C1EB 0653 DB8B A557 3829 00F9 D60F 941A 3186 03B6 X-Phone: +30-944-116520 Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 2002-07-15 13:37 +0000, Dag-Erling Smorgrav wrote: > Giorgos Keramidas writes: > > What's wrong with sizeof(...)? I thought that style(9) was actually > > encouraging the use of parentheses for the arguments of sizeof, when > > it mentioned: > > > > Casts and sizeof's are not followed by a space. Note that > > indent(1) does not understand this rule. > > There are two different cases - one is "sizeof(type)" which requires > parentheses, the other is "sizeof variable" which doesn't. In the > latter case, the rule about avoiding unnecessary parentheses applies. Ah ! [ enlightenment ] That would require a major style sweep in ln.c though. Such changes should be done in a separate commit, right? To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message