From owner-svn-src-all@FreeBSD.ORG Sat Nov 8 17:00:09 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 7C416414; Sat, 8 Nov 2014 17:00:09 +0000 (UTC) Received: from mail-qg0-x22d.google.com (mail-qg0-x22d.google.com [IPv6:2607:f8b0:400d:c04::22d]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2FFCF326; Sat, 8 Nov 2014 17:00:09 +0000 (UTC) Received: by mail-qg0-f45.google.com with SMTP id z107so3787647qgd.18 for ; Sat, 08 Nov 2014 09:00:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type; bh=pDDvBC0LY81qIl4pdNVSYWTzHRX3Vj+RK2Zwcbu1xyU=; b=qHgbjW/pLQj7RzMuC+RCXGcXxLQawaOKVQTF9UikyczFnlPfadoGtb02v8hgQvLTDY JUEXKsRP2IkKMTX4KZjMLG9rc7Iqq4MQDk7YU0AtX3N1PAQRYIbE0kiY2umiTzWHZ67e //vw/WK1+Xga3k3VtVYumj4CAFhPbP91A7tDGN1cV1T6/ndBqVyiDhvsPVigsOCcPnGQ zg8SuGP0F7SxTnki10TaQP8uyisB+XDpvrSqHUs2TOEXfLWH7SrWAkh1rHrwSHabXxIA r8qASFb1l2Y662xCWXN8sKYurQzi3KdiHKLgTFUwdaYKP9qi4bE8WSjZO5VL+fjWsNt9 C+GQ== X-Received: by 10.224.47.4 with SMTP id l4mr15827268qaf.36.1415466008343; Sat, 08 Nov 2014 09:00:08 -0800 (PST) Received: from kan ([2601:6:6780:780:226:18ff:fe00:232e]) by mx.google.com with ESMTPSA id 45sm8741283qgg.37.2014.11.08.09.00.06 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 08 Nov 2014 09:00:07 -0800 (PST) Date: Sat, 8 Nov 2014 12:00:00 -0500 From: Alexander Kabaev To: Mark Johnston Subject: Re: svn commit: r274200 - head/share/mk Message-ID: <20141108120000.3f16feab@kan> In-Reply-To: <201411062246.sA6MkeLN018716@svn.freebsd.org> References: <201411062246.sA6MkeLN018716@svn.freebsd.org> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.22; amd64-portbld-freebsd11.0) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; boundary="Sig_/GivU/EKY5jztYj/V4/o8gyA"; protocol="application/pgp-signature" Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Nov 2014 17:00:09 -0000 --Sig_/GivU/EKY5jztYj/V4/o8gyA Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Thu, 6 Nov 2014 22:46:40 +0000 (UTC) Mark Johnston wrote: > Author: markj > Date: Thu Nov 6 22:46:40 2014 > New Revision: 274200 > URL: https://svnweb.freebsd.org/changeset/base/274200 >=20 > Log: > Automatically build with debug symbols when building with WITH_CTF. > Otherwise there's nothing for ctfconvert to do, and it ends up > emitting an error for each object file. Also remove some redundant > checks from bsd.prog.mk and bsd.lib.mk. =20 > =20 > -.if ${MK_CTF} !=3D "no" && ${DEBUG_FLAGS:M-g} !=3D "" > +.if ${MK_CTF} !=3D "no" > CTFFLAGS+=3D -g > .endif > .else I have a question about this and another similar change. Does it have the effect of always leaving binaries with debug symbols in id WITH_CTF is in effect and do we now rely solely on install stripping binaries at later stage to get rid of the debug symbols? IMHO, we should only pass -g to ctfconvert if WITH_CTF is set _and_ user requested debug symbols explicitly. Your change seems to be breaking that. --=20 Alexander Kabaev --Sig_/GivU/EKY5jztYj/V4/o8gyA Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iD8DBQFUXkwWQ6z1jMm+XZYRAtWdAKCKP07oHjfePn5xbuesqZ9aNIvaXACcCIJw DPBG5lqNxib1TDfWHyXMQ+c= =PfF9 -----END PGP SIGNATURE----- --Sig_/GivU/EKY5jztYj/V4/o8gyA--