From owner-svn-ports-all@FreeBSD.ORG  Sat Feb 21 11:35:54 2015
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 2F33EA83;
 Sat, 21 Feb 2015 11:35:54 +0000 (UTC)
Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 052359ED;
 Sat, 21 Feb 2015 11:35:53 +0000 (UTC)
Received: from [192.168.0.22] (unknown [130.255.19.191])
 (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
 (No client certificate requested)
 by shepard.synsport.net (Postfix) with ESMTP id 0861B43CF2;
 Sat, 21 Feb 2015 05:35:46 -0600 (CST)
Message-ID: <54E86D8B.2000200@marino.st>
Date: Sat, 21 Feb 2015 12:35:39 +0100
From: John Marino <freebsd.contact@marino.st>
Reply-To: marino@freebsd.org
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:24.0) Gecko/20100101 Thunderbird/24.5.0
MIME-Version: 1.0
To: Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org>, 
 ports-committers@freebsd.org, svn-ports-all@freebsd.org, 
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r379501 - head/lang/v8
References: <201502211131.t1LBVwUJ098961@svn.freebsd.org>
In-Reply-To: <201502211131.t1LBVwUJ098961@svn.freebsd.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 21 Feb 2015 11:35:54 -0000

On 2/21/2015 12:31, Sunpoet Po-Chuan Hsieh wrote:
> Author: sunpoet
> Date: Sat Feb 21 11:31:58 2015
> New Revision: 379501
> URL: https://svnweb.freebsd.org/changeset/ports/379501
> QAT: https://qat.redports.org/buildarchive/r379501/
> 
> Log:
>   - Fix build with Clang 3.6.0
>   - Use CXXFLAGS instead of CFLAGS
>   - Simplify CXXFLAGS: all supported Clang are 3.3+
> 
> Modified:
>   head/lang/v8/Makefile
> 
> Modified: head/lang/v8/Makefile
> ==============================================================================
> --- head/lang/v8/Makefile	Sat Feb 21 11:31:53 2015	(r379500)
> +++ head/lang/v8/Makefile	Sat Feb 21 11:31:58 2015	(r379501)
> @@ -32,14 +32,14 @@ python_CMD=	${PYTHON_CMD}
>  .include <bsd.port.pre.mk>
>  
>  .if ${COMPILER_TYPE} == clang
> -CFLAGS+=	-Wno-unused-private-field
> +CXXFLAGS+=	-Wno-nested-anon-types -Wno-unused-function -Wno-unused-private-field
>  MAKE_ENV+=	LINK=clang++
> -.if ${COMPILER_VERSION} >= 33
> -CFLAGS+=	-Wno-nested-anon-types -Wno-unused-function
>  .if ${COMPILER_VERSION} >= 34
> -CFLAGS+=	-Wno-unused-const-variable
> +CXXFLAGS+=	-Wno-unused-const-variable
>  .if ${COMPILER_VERSION} >= 35
> -CFLAGS+=	-Wno-tautological-undefined-compare
> +CXXFLAGS+=	-Wno-tautological-undefined-compare
> +.if ${COMPILER_VERSION} >= 36
> +CXXFLAGS+=	-Wno-unused-local-typedef
>  .endif
>  .endif
>  .endif
> 

Upstream has finally given up and disabled Werror:
https://github.com/joyent/node/commit/f057c7049eea6e6396dfd8117910ccb2a5c8977a

GCC5 needs these fixes too, but you have this limited to clang
(understandably).  V8 really needs this patch from upstream instead
unless v8 is being updated to a newer version imminently.

Shouldn't that patch be used instead?
John