Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 7 Jun 2014 22:07:45 +0100 (BST)
From:      Daniel Austin <freebsd-ports@dan.me.uk>
To:        FreeBSD-gnats-submit@freebsd.org
Cc:        gecko@FreeBSD.org
Subject:   [PATCH] mail/thunderbird-i18n: Fix port extraction
Message-ID:  <201406072107.s57L7jg0080845@bolton.dan.me.uk>

next in thread | raw e-mail | index | archive | help

>Submitter-Id:	current-users
>Originator:	Daniel Austin
>Organization:	N/A
>Confidential:	no 
>Synopsis:	[PATCH] mail/thunderbird-i18n: Fix port extraction
>Severity:	non-critical
>Priority:	low
>Category:	ports
>Class:		change-request
>Release:	FreeBSD 10.0-RELEASE-p3 amd64
>Environment:
System: FreeBSD media2.dan.me.uk 10.0-RELEASE-p3 FreeBSD 10.0-RELEASE-p3 #0: Tue May 13 18:31:10 UTC 2014 root@amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC amd64

>Description:
	Fix port extraction after PR/188419 was applied (USES=zip changes)

	CC'd maintainer
>How-To-Repeat:
	
>Fix:

Change extraction code to use system unzip instead of infozip's unzip on do-extract

Tested with poudriere - see logs at http://poudriere.dan.tm/latest-per-pkg/thunderbird-i18n/24.5.0_1/

--- 20140607-thunderbird-i18n.diff begins here ---
diff -ruN thunderbird-i18n.orig/Makefile thunderbird-i18n/Makefile
--- thunderbird-i18n.orig/Makefile	2014-06-06 16:26:41.000000000 +0100
+++ thunderbird-i18n/Makefile	2014-06-07 17:08:57.188196439 +0100
@@ -3,6 +3,7 @@
 
 PORTNAME=	thunderbird-i18n
 PORTVERSION=	24.5.0
+PORTREVISION=	1
 CATEGORIES=	mail news net-im
 MASTER_SITES=	MOZILLA/${PORTNAME:S|-i18n||}/releases/${PORTVERSION}/linux-i686/xpi
 PKGNAMEPREFIX=
@@ -12,8 +13,6 @@
 MAINTAINER=	gecko@FreeBSD.org
 COMMENT=	Localized interface for Thunderbird
 
-EXTRACT_DEPENDS=	zip:${PORTSDIR}/archivers/zip
-
 USES=		gecko:thunderbird zip
 USE_XPI=	thunderbird
 
@@ -48,7 +47,7 @@
 	@${RM} -rf ${WRKDIR}
 	@${MKDIR} ${WRKDIR} ${WRKSRC}
 	@for lang in ${THUNDERBIRD_I18N_}; do \
-		if ! (${UNZIP_CMD} -qo ${_DISTDIR}/$$lang.xpi -d ${WRKSRC}/langpack-$$lang@thunderbird.mozilla.org);\
+		if ! (${EXTRACT_CMD} -qo ${_DISTDIR}/$$lang.xpi -d ${WRKSRC}/langpack-$$lang@thunderbird.mozilla.org);\
 		then \
 			exit 1; \
 		fi; \
--- 20140607-thunderbird-i18n.diff ends here ---





Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201406072107.s57L7jg0080845>