Date: Fri, 26 Apr 2013 11:51:38 +0300 From: Alex Kozlov <ak@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r316515 - head/graphics/gdk-pixbuf2 Message-ID: <20130426085138.GA5097@ravenloft.kiev.ua> In-Reply-To: <20130426035132.GA77202@FreeBSD.org> References: <201304251344.r3PDid1c079303@svn.freebsd.org> <20130426035132.GA77202@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Apr 26, 2013 at 03:51:32AM +0000, Alexey Dokuchaev wrote: > On Thu, Apr 25, 2013 at 01:44:39PM +0000, Alex Kozlov wrote: > > New Revision: 316515 > > URL: http://svnweb.freebsd.org/changeset/ports/316515 > > > > <...> > > - Remove NLS from options, it's handled globally > > It looks like we do need a policy on this issue. Recently it was discussed > (google for "Re: svn commit: r315222") again for example. Some guidelines would be nice to have. > I personally think that all options should be listed in OPTIONS_DEFINE, even > the global ones. The nice thing here that if some option(s) will migrate > their local<->global status, we would not have to change OPTIONS_DEFINE in > thousands places across the tree. It would also mean no diversity; right > now some people list them, while some don't. I personally think that global options should not be generally listed, but maintainer should have the last word. > As for addressing the annoyance part of the question, it should be solved > with separate knob, settable in /etc/make.conf, that users can set to skip > the global options in dialog (or disable skipping if it's on by default). > OPTIONS_DEFINE should not be abused for this purpose. Perhaps, but I prefer knob which adds global options to dialog. -- Alex
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130426085138.GA5097>