Date: Tue, 19 May 1998 12:58:47 -0300 (EST) From: Joao Carlos Mendes Luis <jonny@jonny.eng.br> To: hasty@rah.star-gate.com (Amancio Hasty) Cc: luigi@labinfo.iet.unipi.it, ahasty@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG, roger@cs.strath.ac.uk, multimedia@FreeBSD.ORG Subject: Re: cvs commit: src/sys/pci brooktree848.c Message-ID: <199805191558.MAA16087@roma.coe.ufrj.br> In-Reply-To: <199805190655.XAA00354@rah.star-gate.com> from Amancio Hasty at "May 18, 98 11:55:45 pm"
next in thread | previous in thread | raw e-mail | index | archive | help
#define quoting(Amancio Hasty) // When either you or Roger can verify the new sysctl hw.bt848.format, // I will commit the fix. // // hw.bt848.format = 0 | 1 // // 0 Denotes PAL // 1 Denotes NTSC Shouldn't there be also the sub-formats, like NTSM/M, NTSC/J, PAL/I, PAL/M, etc ? I'm thinking of the BT848SFMT ioctl, and not the old compatibility METEORSFMT one. BTW: Somebody has messed up PAL/M again. PAL/M is NTSC-like, not PAL-like, despite it's name. It's indeed a 60/525 system with support for Phase Alternated Lines (PAL). So the ioctl BT848SFMT has to be changed, and, please, add a comment to avoid future changes. Curiously, the struct format_params seems unchanged. Unfortunatly, I don't have a bt848 anymore to test these. While I'm here, I'd like to note that sysctl is somewhat like SNMP, and SNMP variables have a unit name as this small extract from a snmpwalk shows. interfaces.ifTable.ifEntry.ifInOctets.1 = 204219604 interfaces.ifTable.ifEntry.ifInOctets.2 = 0 interfaces.ifTable.ifEntry.ifInOctets.3 = 0 interfaces.ifTable.ifEntry.ifInOctets.4 = 32787782 interfaces.ifTable.ifEntry.ifInOctets.5 = 0 Things that have the notion of units should reflect this in its sysctl, even if 99.999% of people only have one of those interfaces. Of course, this is just my very humble opinion. Jonny -- Joao Carlos Mendes Luis M.Sc. Student jonny@jonny.eng.br Universidade Federal do Rio de Janeiro To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199805191558.MAA16087>